This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Fix/clean_up ModuleDependency's hashCode, equals, compareTo trio | ||
|---|---|---|---|
| Product: | apisupport | Reporter: | Martin Krauskopf <mkrauskopf> |
| Component: | Project | Assignee: | Martin Krauskopf <mkrauskopf> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | ||
| Priority: | P1 | ||
| Version: | 5.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | TASK | Exception Reporter: | |
|
Description
Martin Krauskopf
2006-02-08 17:32:03 UTC
BTW I recently added hashCode for some classes with equals, acc. to FindBugs; hope it was correct. Surely not :). I just think I misunderstand some concepts in the beginning so I presumably caused a little mess on some places which use ModuleDependencies (mainly in the GUI). test/unit/ui/customizer/ModuleDependencyTest.java; 1.3 -> 1.4; ProjectXMLManager.java; 1.44 -> 1.45; ui/LibrariesNode.java; 1.7 -> 1.8; ui/customizer/ModuleDependency.java; 1.19 -> 1.20; ui/customizer/SingleModuleProperties.java; 1.53 -> 1.54; Forgot mark as fixed. Backported into 5.0u1 project/ProjectXMLManager.java; 1.44 -> 1.44.2.1; project/ui/customizer/ModuleDependency.java; 1.19 -> 1.19.2.1; project/ui/customizer/SingleModuleProperties.java; 1.53 -> 1.53.2.1; project/test/unit/ui/customizer/ModuleDependencyTest.java; 1.3 -> 1.3.6.1; project/ui/LibrariesNode.java; 1.7 -> 1.7.2.1; Note this was actually bug (and/or allows to fix another one) Note: as part of issue #72463 I will discard most of this, so that MD instances are compared and sorted only by code name base. This is not mathematically accurate but I think it doesn't matter - AFAIK there will never be two MD's with the same code name base in one set at once. And supporting lazy evaluation of the specification version while retaining mathematical correctness is just not possible. Review will be requested. |