This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 58941

Summary:	ProxyLookup caches Templates
Product:	platform	Reporter:	Martin Roskanin <mroskanin>
Component:	Lookup	Assignee:	Jaroslav Tulach <jtulach>
Status:	CLOSED FIXED
Severity:	blocker
Priority:	P3
Version:	4.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Attachments:	ProxyLookupTest diff

Description Martin Roskanin 2005-05-16 09:35:05 UTC

Reproduction:
- create ProxyLookup with one lookup that contains one object i.e. String
- perform lookup via Template of String.class
- replace lookup in ProxyLookup. New lookup will contain one object i.e Integer
- perform lookup via Tempate of String.class
-> instance of String.class is found, although it already shouldn't be presented
in ProxyLookup

For more details, see attached test diff

Comment 1 Martin Roskanin 2005-05-16 09:36:35 UTC

Created attachment 22140 [details]
ProxyLookupTest diff

Comment 2 Jaroslav Tulach 2005-06-12 16:45:06 UTC

cvs -q ci -m "#58941: The array passed to setLookups was thought as not 
modifiable and if someone modified it and setLookups once again things were 
obviously broken. Making clone of the array in setLookups and also creating 
clone in getLookups. Testing both cases." 
 
 
Checking in src/org/openide/util/lookup/ProxyLookup.java; 
/cvs/openide/util/src/org/openide/util/lookup/ProxyLookup.java,v  <--  
ProxyLookup.java 
new revision: 1.2; previous revision: 1.1 
done 
Checking in test/unit/src/org/openide/util/lookup/ProxyLookupTest.java; 
/cvs/openide/util/test/unit/src/org/openide/util/lookup/ProxyLookupTest.java,v  
<--  ProxyLookupTest.java 
new revision: 1.2; previous revision: 1.1

Comment 3 Martin Roskanin 2005-06-17 14:28:23 UTC

Verified. Thanks.