This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | API change: org.netbeans.api.debugger.jpda.LineBreakpoint | ||
---|---|---|---|
Product: | debugger | Reporter: | Libor Kotouc <lkotouc> |
Component: | Java | Assignee: | apireviews <apireviews> |
Status: | CLOSED FIXED | ||
Severity: | blocker | CC: | jjancura |
Priority: | P3 | Keywords: | API_REVIEW_FAST |
Version: | 4.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: |
LineBreakpoint diff
Diffs: manifest.mf, apichanges.xml, LineBreakpoint.java Generated Javadoc with changes. LineBreakpointImpl diff JPDA Debugger + JPDA Debugger API diffs Test files |
Description
Libor Kotouc
2005-02-04 09:12:32 UTC
Created attachment 20187 [details]
LineBreakpoint diff
This cannot be integrated in current state. The change needs to use @since tag, increment spec. version in manifest, update api changes and write a test to show why this method is good for. Moreover the methods should be final, I guess. Please provide better version of the patch. Created attachment 20349 [details]
Diffs: manifest.mf, apichanges.xml, LineBreakpoint.java
Created attachment 20350 [details]
Generated Javadoc with changes.
Requested enhacements attached. apichanges, javadoc and manifest changes are ok. Just do not forget to increase the dependency of modules using this method to version 1.3. The test is still missing, which I consider major problem, but I am ready to help writing it if you want. I would start by extending or copying debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/LineBreakpointTest.java to fail on your JspBreakpoint without the api changes and then prove that it works after that. Created attachment 20484 [details]
LineBreakpointImpl diff
Created attachment 20608 [details]
JPDA Debugger + JPDA Debugger API diffs
Created attachment 20609 [details]
Test files
I attached the requested tests and final diffs for JPDA Debugger and JPDA Debugger modules. Checking in api/apichanges.xml; /cvs/debuggerjpda/api/apichanges.xml,v <-- apichanges.xml new revision: 1.8; previous revision: 1.7 done Checking in api/manifest.mf; /cvs/debuggerjpda/api/manifest.mf,v <-- manifest.mf new revision: 1.8; previous revision: 1.7 done Processing log script arguments... More commits to come... Checking in api/src/org/netbeans/api/debugger/jpda/LineBreakpoint.java; /cvs/debuggerjpda/api/src/org/netbeans/api/debugger/jpda/LineBreakpoint.java,v <-- LineBreakpoint.java new revision: 1.7; previous revision: 1.6 done Processing log script arguments... More commits to come... RCS file: /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/JspLineBreakpointApp.txt,v done Checking in test/unit/src/org/netbeans/api/debugger/jpda/testapps/JspLineBreakpointApp.txt; /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/JspLineBreakpointApp.txt,v <-- JspLineBreakpointApp.txt initial revision: 1.1 done RCS file: /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/JspLineBreakpointApp.java,v done Checking in test/unit/src/org/netbeans/api/debugger/jpda/testapps/JspLineBreakpointApp.java; /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/JspLineBreakpointApp.java,v <-- JspLineBreakpointApp.java initial revision: 1.1 done Processing log script arguments... More commits to come... RCS file: /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/d/included.jsp,v done Checking in test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/d/included.jsp; /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/d/included.jsp,v <-- included.jsp initial revision: 1.1 done Processing log script arguments... More commits to come... RCS file: /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/included.jsp,v done Checking in test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/included.jsp; /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/included.jsp,v <-- included.jsp initial revision: 1.1 done RCS file: /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/index.jsp,v done Checking in test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/index.jsp; /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/resources/index.jsp,v <-- index.jsp initial revision: 1.1 done Processing log script arguments... More commits to come... RCS file: /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/JspLineBreakpointTest.java,v done Checking in test/unit/src/org/netbeans/api/debugger/jpda/JspLineBreakpointTest.java; /cvs/debuggerjpda/test/unit/src/org/netbeans/api/debugger/jpda/JspLineBreakpointTest.java,v <-- JspLineBreakpointTest.java initial revision: 1.1 done Checking in LineBreakpointImpl.java; /cvs/debuggerjpda/src/org/netbeans/modules/debugger/jpda/breakpoints/LineBreakpointImpl.java,v <-- LineBreakpointImpl.java new revision: 1.19; previous revision: 1.18 done Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier. |