This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | ModuleChangeDescriptor should provide list of all changed files | ||
|---|---|---|---|
| Product: | serverplugins | Reporter: | Nam Nguyen <nnguyen> |
| Component: | Infrastructure | Assignee: | Nam Nguyen <nnguyen> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | apireviews, ludo, marcow, pbuzek |
| Priority: | P1 | Keywords: | API_REVIEW_FAST |
| Version: | 4.x | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Attachments: | Adding ModuleChangeDescriptor.getChangedFiles | ||
This is trivial and compatible change. Created attachment 19757 [details]
Adding ModuleChangeDescriptor.getChangedFiles
Diffs of apichanges.xml, ModuleChangeDescriptor, ServerFileDistributor are included. Proposed changes checked in: /cvs/j2eeserver/apichanges.xml,v <-- apichanges.xml new revision: 1.8; previous revision: 1.7 /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerFileDistributor.java,v <-- ServerFileDistributor.java new revision: 1.19; previous revision: 1.18 /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/ModuleChangeDescriptor.java,v <-- ModuleChangeDescriptor.java new revision: 1.4; previous revision: 1.3 this must have been missed |
Currently ModuleChangeDescriptor only provide the following types of change: deployment descriptor, server-specific descriptor, classes, manifest. This prove to be insufficient and in the past year for more than once we had to update the list of file suffixes to check for changes. There is no reason for not providing plugin with all the list of file changes as proposed following: ModuleChangeDescriptor { /** * Returns list of relative paths of changed files. */ File[] getChangedFiles(); } This is a compatible change. ModuleChangeDescriptor is implemented by deployment code in j2eeserver and the new method getChangedFiles would only be used by plugin code when all the existing methods are not sufficient to address some server specific corner cases.