This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Change Method Parameters does not work with HttpServletRequest & HttpServletResponse args | ||
|---|---|---|---|
| Product: | editor | Reporter: | Charlie Hunt <huntch> |
| Component: | Refactoring | Assignee: | Ralph Ruijs <ralphbenjamin> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | blocker | CC: | bleonard |
| Priority: | P3 | ||
| Version: | 4.x | ||
| Hardware: | PC | ||
| OS: | Windows ME/2000 | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 65780 | ||
| Attachments: |
Full copy of the source code
Display of Help > About > Detail information in a bmp file. |
||
Created attachment 19572 [details]
Full copy of the source code
Created attachment 19573 [details]
Display of Help > About > Detail information in a bmp file.
Sorry, but this is currently as designed. Change method parameters will let you add new parameters or remove the ones that are not used by the method. You cannot change types of parameters since the refactoring would not know what to do with the usages of that method. If this is the way it is currently designed, then the defect is in the name of given to the type of refactoring. The name given to the type of refactoring should be "Add / Remove Method Parameters", not "Change Method Parameters". The latter implies a sort of operation as I described in addition to Add / Remove. Forgot to re-open issue on last commit. This is definitely not a P1. My personal opinion is that it is better to call this feature Change Method Parameters than Add/Remove/Reorder Method Parameters. Anyway, we will discuss this with our UI engineer. Reassigning to UI team. Rudolfe, please make a decision. This is implemented accroding to ui spec. Changing issue type to enhancement. |
This is an isse I have found with NetBeans 4.1 Build 20041222-1722. I have a method in a servlet called dispatchToWorker(HttpServletRequest theRequest, HttpServletResponse theResponse). As you can see, it has two args, theRequest and theResponse. This method is called from the servlet's processRequest(..) method. I wanted to refactor the dispatchToWorker() method to change HttpServletResponse theResponse to PrintWriter thePrintWriter. But, the Change Method Parameters dialog will not let me change that parameter or remove it. BTW: It also won't let me change HttpServletRequest theRequest either. Here's what the source looks like: protected void dispatchToWorker(HttpServletRequest theRequest, HttpServletResponse theResponse) throws IOException { .... } protected void processRequest(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { response.setContentType("text/html"); dispatchToWorker(request, response); }