This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Fast track review of PropertyPanel rewrite API changes | ||
---|---|---|---|
Product: | platform | Reporter: | _ tboudreau <tboudreau> |
Component: | Explorer | Assignee: | apireviews <apireviews> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | Keywords: | API_REVIEW_FAST |
Priority: | P1 | ||
Version: | 3.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Bug Depends on: | 37779, 37780 | ||
Bug Blocks: | 31896 | ||
Attachments: |
JDiff diff of PropertyPanel class (note some mentioned methods are simply overrides of JComponent methods)
Javadoc for PropertyPanel from the branch Diff of explorer docs, arch answers & openide-spec-version |
Description
_ tboudreau
2003-12-01 10:21:33 UTC
Created attachment 12366 [details]
JDiff diff of PropertyPanel class (note some mentioned methods are simply overrides of JComponent methods)
Created attachment 12367 [details]
Javadoc for PropertyPanel from the branch
One unrelated change which occurs on this branch: Remove method org.openide.explorer.propertysheet.InplaceEditor.handleInitialInputEvent I found it is equally effective to just dispatch the appropriate event to an inplace editor using normal methods. If an inplace editor needs to handle it in a different way because it is the initial event, it knows if it was just added to a container. The interface InplaceEditor was new with the property sheet rewrite, and has never been published in a stable release of NetBeans - so not only is this a compatible change, it is not even a change to the official APIs. Created attachment 12369 [details]
Diff of explorer docs, arch answers & openide-spec-version
Adding API_REVIEW_FAST keyword. If nobody objects, this is accepted on Dec 8th. I am amazed. Only small API changes, tons of tests testing various interactions and even! that correct icon is rendered at desired possition. I think I could not write that better (not counting that I have not write UI stuff for years), but still as a reviewer I have to have some comments: - next time, please diff -u when generating diffs - request for better documentation described in issue 37780 - request for providing compatibility bridge put into issue 37779 - my advice is to condider putting all resources (icons, etc.) directly into org.openide.explorer.propertysheet package, this would be step towards openide.jar separation - my advice is to eliminate call to org.netbeans.core.NonGui.registerEditors() from tests if possible, as this methods is a candidate for removal. - small advice is to create a special category of tests in openide/test/cfg-unit so people could just start those colorful, joy to watch tests of propertysheet and do not need to wait for those boring GUI-less tests of CompilationEngine, etc. (just make sure it is still executed by default when doing ant -f openide/test/build.xml). Beyond my two requests above I have no idea what, from architecture point of view could prevent integration of such beautiful improvement. Re org.netbeans.core.NonGui.registerEditors() - this is mainly because we do test the boolean editors, and the JDK boolean editor doesn't support getTags(). There are workarounds in the property sheet package for platform use, where that may be missing, but the tests rely on our boolean editor. Would it not be better to separate the core property editors for JDK classes into their own module? Property panel branch integrated into trunk. |