This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Separate org.openide.util to separate package | ||
---|---|---|---|
Product: | platform | Reporter: | Jaroslav Tulach <jtulach> |
Component: | -- Other -- | Assignee: | Jaroslav Tulach <jtulach> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | jchalupa, jglick, mzlamal, phrebejk, pzavadsky, tboudreau, ttran |
Priority: | P1 | Keywords: | ARCH |
Version: | 3.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 19443, 29460 | ||
Attachments: |
The changes to be applied
The diff against main trunk with current state of the branch |
Description
Jaroslav Tulach
2002-12-11 14:10:59 UTC
Created branch jars_29458 rooted at BLD200309090100 that will turn these package and also others into own JAR files. Branched modules now include nbbuild and openide. Working on it. I think I am ready to merge this to trunk. Will do it after two weeks when I return back from vacation. I'd be glad if you could review that meanwhile, Jesse. Created attachment 11796 [details]
The changes to be applied
It might be worth splitting propertysheet into a separate jar, rather than including it in openide-explorer - the contents are fairly distinct, and in the long run I want to do this anyway, so might as well do it now. Separating propertysheet is more task that belongs to issue 34758, which has already been finished. Anyway thanks for noticing that separation is going on and doing a review. As concern separation propertysheet from explorer, I do not think that the "the contents are fairly distinct". I know you would like them to be, but significant parts of both packages work around Node and ExplorerManager and are fairly connected. I am aware of your effort to have independent propertysheet, but it would be better addressed by writing completely new module than hacking around old org.openide package. If necessary, the old org.openide.explorer.propertysheet can depend and use the new old stuff (after most openide-*.jar are turned to modules). You still need to do some merging from the trunk. In particular, the merge of nbbuild/build.properties will be nontrivial since the trunk version factors out lists of modules in a more sophisticated way than what you branched. Should not be so hard, though. I am making some misc. fixes and also merging the JavaHelp 2.0 changes to the branch, which are necessary in order for core/javahelp to compile. Branch synchronized with main trunk tag BLD200310060100 I have renamed openide-*.jar modules to not end with /1 do you think that now it is ready for merge, Jesse? Hrebejk, would you mind to do me a review? Assuming it still builds, unit tests still pass, etc., I don't know of any outstanding problems that would prevent a merge. Thanks Jesse. I will have the change review by Michal Zlamal on Monday and if he finds it acceptable and reasonable as well, I'll commit it. things to remember: - projects (O/S & C/S) - winsys branch: Peter should sync up his branch ASAP after the merge Created attachment 11863 [details]
The diff against main trunk with current state of the branch
I propose to move the sources in CVS and split javadoc of all openide packages after we branch 4.1. For performance reasons I prefer to keep one resulting openide.jar file, its split may come later. Fixed by integration of issue 58258. |