Bug 258806

Alexander, great first version!
There are some problems with used color in Dark Theme

Also, could you put Launchers into project Properties dialog?

Please, change icons to nicer (i.e. from navigator):
Suggestions:
private common - private constructor icon
public  common - public constructor icon
private launcher - private field icon
public  launcher - public field icon

Btw, when checkbox "Private" changes state icon now doesn't change it's presentation

VV3: Manager Launchers... shows nothing from Files view (works only from Projects view)

(In reply to Vladimir Voskresensky from comment #3)
> Btw, when checkbox "Private" changes state icon now doesn't change it's
> presentation
VV2: I meant "Public launcher" checkbox doesn't affect icon

VV4: it's worth to have tooltips.
I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro

VV5: Run Command uses control which is difficult to review/modify. It should be like script body in SendTo config panel

VV6: Run Directory and Symbol Files should have "..." to choose directory/file in File Chooser

Integrated into 'main-silver', will be available in build *201604140001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/4bff67a88bea
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixing Bug #258806 Implement Run/Debug launchers UI

(In reply to Vladimir Voskresensky from comment #1)
> Alexander, great first version!
> There are some problems with used color in Dark Theme
> 
> Also, could you put Launchers into project Properties dialog?
I think, we can have in Project properties Launcher node on the left (in tree) and in Panel we can have just list of launchers with Up/Down + Manage... which will open the current dialog

(In reply to Vladimir Voskresensky from comment #5)
> (In reply to Vladimir Voskresensky from comment #3)
> > Btw, when checkbox "Private" changes state icon now doesn't change it's
> > presentation
> VV2: I meant "Public launcher" checkbox doesn't affect icon
fixed in change set:
http://hg.netbeans.org/cnd-main/rev/b5ab4ae5c549

(In reply to Vladimir Voskresensky from comment #4)
> VV3: Manager Launchers... shows nothing from Files view (works only from
> Projects view)

fixed, change set:
http://hg.netbeans.org/cnd-main/rev/852f5417ae72

(In reply to Vladimir Voskresensky from comment #6)
> VV4: it's worth to have tooltips.
> I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro

fived, change set:
http://hg.netbeans.org/cnd-main/rev/322ec87fe45f

(In reply to Vladimir Voskresensky from comment #7)
> VV5: Run Command uses control which is difficult to review/modify. It should
> be like script body in SendTo config panel

fixed, change set:
http://hg.netbeans.org/cnd-main/rev/0a278d6d9447

(In reply to Alexander Simon from comment #13)
> (In reply to Vladimir Voskresensky from comment #6)
> > VV4: it's worth to have tooltips.
> > I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro
> 
> fived, change set:
> http://hg.netbeans.org/cnd-main/rev/322ec87fe45f

VV7: please, add tooltip to controls as well (i.e. table, textbox), not to control lables only

(In reply to Vladimir Voskresensky from comment #2)
> Please, change icons to nicer (i.e. from navigator):
> Suggestions:
> private common - private constructor icon
> public  common - public constructor icon
> private launcher - private field icon
> public  launcher - public field icon

Do not think that reusing code model icons is a good idea.
Do not fix.

(In reply to Vladimir Voskresensky from comment #15)
> (In reply to Alexander Simon from comment #13)
> > (In reply to Vladimir Voskresensky from comment #6)
> > > VV4: it's worth to have tooltips.
> > > I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro
> > 
> > fived, change set:
> > http://hg.netbeans.org/cnd-main/rev/322ec87fe45f
> 
> VV7: please, add tooltip to controls as well (i.e. table, textbox), not to
> control lables only

Do not think that it is a good idea. The tool tip on fields will disturb user to see field content. Do not fix.

(In reply to Vladimir Voskresensky from comment #10)
> (In reply to Vladimir Voskresensky from comment #1)
> > Alexander, great first version!
> > There are some problems with used color in Dark Theme
> > 
> > Also, could you put Launchers into project Properties dialog?
> I think, we can have in Project properties Launcher node on the left (in
> tree) and in Panel we can have just list of launchers with Up/Down +
> Manage... which will open the current dialog

I do not think that it is a good idea. Or action in pop-up menu or node in project properties.
But anyway, fixed, change set:
http://hg.netbeans.org/cnd-main/rev/d9caf9c32cf2

(In reply to Alexander Simon from comment #16)
> (In reply to Vladimir Voskresensky from comment #2)
> > Please, change icons to nicer (i.e. from navigator):
> > Suggestions:
> > private common - private constructor icon
> > public  common - public constructor icon
> > private launcher - private field icon
> > public  launcher - public field icon
> 
> Do not think that reusing code model icons is a good idea.
> Do not fix.
VV8: The current icons are bad (especially on dark L&F)
Please, choose any other public/private from existing ones

(In reply to Alexander Simon from comment #17)
> (In reply to Vladimir Voskresensky from comment #15)
> > (In reply to Alexander Simon from comment #13)
> > > (In reply to Vladimir Voskresensky from comment #6)
> > > > VV4: it's worth to have tooltips.
> > > > I.e. in tooltip for Symbol Files you can propose use of ${OUTPUT_PATH} macro
> > > 
> > > fived, change set:
> > > http://hg.netbeans.org/cnd-main/rev/322ec87fe45f
> > 
> > VV7: please, add tooltip to controls as well (i.e. table, textbox), not to
> > control lables only
> 
> Do not think that it is a good idea. The tool tip on fields will disturb
> user to see field content. Do not fix.
VV9: add it at least for env table

(In reply to Vladimir Voskresensky from comment #19)
> (In reply to Alexander Simon from comment #16)
> > (In reply to Vladimir Voskresensky from comment #2)
> > > Please, change icons to nicer (i.e. from navigator):
> > > Suggestions:
> > > private common - private constructor icon
> > > public  common - public constructor icon
> > > private launcher - private field icon
> > > public  launcher - public field icon
> > 
> > Do not think that reusing code model icons is a good idea.
> > Do not fix.
> VV8: The current icons are bad (especially on dark L&F)
> Please, choose any other public/private from existing ones
As alternative you can use "Run Main Project" & "Run Project" icons

(In reply to Vladimir Voskresensky from comment #8)
> VV6: Run Directory and Symbol Files should have "..." to choose
> directory/file in File Chooser

"Run File system" belongs to configuration. Project can have several configurations with different file systems. So impossible to create file chooser for unknown file system.
Do not fix.

Created attachment 159273 [details]
To demonstrate VV8: The current icons are bad (especially on dark L&F)

(In reply to Vladimir Voskresensky from comment #21)
> (In reply to Vladimir Voskresensky from comment #19)
> > (In reply to Alexander Simon from comment #16)
> > > (In reply to Vladimir Voskresensky from comment #2)
> > > > Please, change icons to nicer (i.e. from navigator):
> > > > Suggestions:
> > > > private common - private constructor icon
> > > > public  common - public constructor icon
> > > > private launcher - private field icon
> > > > public  launcher - public field icon
> > > 
> > > Do not think that reusing code model icons is a good idea.
> > > Do not fix.
> > VV8: The current icons are bad (especially on dark L&F)
> > Please, choose any other public/private from existing ones
> As alternative you can use "Run Main Project" & "Run Project" icons

I do not think that icons are bad (see comment #23)
Please move this topic in separate enchantment.

(In reply to Alexander Simon from comment #24)
> (In reply to Vladimir Voskresensky from comment #21)
> > (In reply to Vladimir Voskresensky from comment #19)
> > > (In reply to Alexander Simon from comment #16)
> > > > (In reply to Vladimir Voskresensky from comment #2)
> > > > > Please, change icons to nicer (i.e. from navigator):
> > > > > Suggestions:
> > > > > private common - private constructor icon
> > > > > public  common - public constructor icon
> > > > > private launcher - private field icon
> > > > > public  launcher - public field icon
> > > > 
> > > > Do not think that reusing code model icons is a good idea.
> > > > Do not fix.
> > > VV8: The current icons are bad (especially on dark L&F)
> > > Please, choose any other public/private from existing ones
> > As alternative you can use "Run Main Project" & "Run Project" icons
> 
> I do not think that icons are bad (see comment #23)
> Please move this topic in separate enchantment.
I agree 
https://netbeans.org/bugzilla/show_bug.cgi?id=258837

Integrated into 'main-silver', will be available in build *201604150001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c84c7e8d8cd1
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixing Bug #258806 Implement Run/Debug launchers UI
- fix icon in dark L&F

Integrated into 'main-silver', will be available in build *201604160001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a807a45dd3ae
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixing Bug #258806 Implement Run/Debug launchers UI
- beautifying icons

Integrated into 'main-silver', will be available in build *201604261340* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/f15c475411fe
User: Vladimir Voskresensky <vv159170@netbeans.org>
Log: extra fix for #258806 - Implement Run/Debug launchers UI
- zero is a valid index for launcher; use constants instead of negatives with special meanings