This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | new maven command line extension for windows change from .bat to .cmd | ||
---|---|---|---|
Product: | projects | Reporter: | skygo <skygo> |
Component: | Maven | Assignee: | Tomas Stupka <tstupka> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | billdacat, emegeve, ent38, hanasaki, megascus, mkleint, tanyehzheng |
Priority: | P2 | ||
Version: | 8.1 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
URL: | https://jira.codehaus.org/browse/MNG-5776 | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 253246 | ||
Attachments: |
patch for windows command line
mock maven jar |
Description
skygo
2015-03-16 16:42:21 UTC
thanks for the patch. will apply asap ... fixed in jet-main #96f725785a9c Created attachment 152698 [details]
mock maven jar
I'am not sure of the cryptic commit diff for the jars uses in the tests. I pass them as zip file in case it need to be scan.
thanks for applying
> I'am not sure of the cryptic commit diff for the jars uses in the tests. I pass them as zip file in case it need to be scan.
completely missed that, thanks ...
Integrated into 'main-silver', will be available in build *201503190001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/96f725785a9c User: Tomas Stupka <tstupka@netbeans.org> Log: Issue #251213 - new maven command line extension for windows change from .bat to .cmd *** Bug 251273 has been marked as a duplicate of this bug. *** Comment on attachment 152656 [details]
patch for windows command line
Can we just check for the existence of the mvn.bat file to determine whether to execute mvn.bat or mvn.cmd?
I think it'll be more clear and faster than MavenSettings.getCommandLineMavenVersion(mavenHome)
(In reply to tanyehzheng from comment #7) > Comment on attachment 152656 [details] > patch for windows command line > > Can we just check for the existence of the mvn.bat file to determine whether > to execute mvn.bat or mvn.cmd? > I think it'll be more clear and faster than > MavenSettings.getCommandLineMavenVersion(mavenHome) Once .getCommandLineMavenVersion is called all subsequent calls are usually fast (measured on my laptop it got down somewhere between 5 - 40ms). Considering that and also the fact that it has to be called at other places during mvn execution anyway, it seems to be better to stay with a clean semantic instead of a potentially dangerous and misleading guess-like heuristic. also that in case .getCommandLineMavenVersion turns out to be a significant performance problem, we should consider caching the mvn version Thanks for your explanation. *** Bug 251380 has been marked as a duplicate of this bug. *** *** Bug 251487 has been marked as a duplicate of this bug. *** *** Bug 251534 has been marked as a duplicate of this bug. *** *** Bug 252442 has been marked as a duplicate of this bug. *** *** Bug 253038 has been marked as a duplicate of this bug. *** Nightly verified working. Current 8.0.2 cannot be used with current maven release 3.3.3 or other released maven versions that have needed bug fixes. Request the fix in nightly be backported to 8.0.2 and released has 8.0.2.1 Tested Maven 3.3.3 with NB 8.0.2. A workaround is to do the following 2 steps. 1. rename mvn.cmd to mvn.bat 2. edit line 100 and rename mvn.cmd to mvn.bat *** Bug 253627 has been marked as a duplicate of this bug. *** Same happends with Maven 3.3.9 > Same happends with Maven 3.3.9
i have to ask to be sure - what NB version/build do you use
please also attach your messages.log from a NB session in which you reproduced this problem
thanks
no response for a couple of weeks. this was fixed in march and should be fixed in 8.1. closing for now. feel free to reopen in case this is reproducible with a current dev build or 8.1 or higher |