This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Introduce a visual delimiter for code folding area | ||
|---|---|---|---|
| Product: | editor | Reporter: | host <host> |
| Component: | Code folding | Assignee: | Svata Dedic <sdedic> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mentlicher, mmetelka, ovrabec |
| Priority: | P3 | ||
| Version: | 8.0.1 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Attachments: |
Without Delimiter
With Delimiter Proposed changes |
||
Created attachment 146280 [details]
With Delimiter
There are more components in the sidebar than just code folding indicators, enumerating left to right: * brace matching outline (the gap left to the code folding) * code folding * diff outline 1/ the diff sidebar does not seem to allow to customize background color. If it did, you could eventually changed the braces outline, code folding bar and diff sidebar backgrounds to light gray - the same color as the line number background. 2/ For visual consistency reasons, I believe the background of all those sidebars should be the same - and if changed, the color should be ideally changed at one place for all (and possibly other) sidebars. I propose a slight change in GUI and extending the sidebar with +1 pixel to provide the boundary line as on the screenshot "With delimiter". All the sidebars would be placed into JPanel with settings-configured background + border on the right side configured to settings-defined foreground. The JPanel's fore color would remain the default. This way the current mechanism that inherits colors from Swing hierarchy parents could work. Please share your opinions; thanks. Created attachment 153509 [details]
Proposed changes
Martin & Mila, please review the proposed changes in your modules: I've changed the logic so that sidebars inherit their background color from the parent, editor core configures the surrounding JPanel with the F&C-defined color, or the linenumber bar color + necessary change monitoring.
If no objections are raised, I'll apply the change on Wednesday.
I've bugfixed :) and changed the attached implementation a little: the coloring defaults to: * sidebar's background = editor's background * line numbers set to the current color in layer This preserves the current color schemes. Users can customize the sidebar overall color and set the line number background to "Inherited". Implemented in jet-main#f55ab8d5b862 Integrated into 'main-silver', will be available in build *201505140001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/f55ab8d5b862 User: Svata Dedic <sdedic@netbeans.org> Log: #243229: Implemented common coloring for sidebar backround Svato, this causes diff sidebar to paint improperly on Nimbus: bug 216364 |
Created attachment 146279 [details] Without Delimiter Currently the area where the code folding elements reside is not visually delimited from the rest of the editor. It would be nice to introduce such a delimiter through a distance background color and delimiting line. On the example screenshots, the editor window is moved two characters to the right and so one can only see e.g. "ckage" and "port". Without visual delimiter, it is not directly clear that the two characters are to the left of the actual editing area (see first screenshot). With the visual delimiter this is much clearer and directly obvious.