This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Improve comment handling for hints and refactorings | ||
|---|---|---|---|
| Product: | java | Reporter: | Svata Dedic <sdedic> |
| Component: | Source | Assignee: | Svata Dedic <sdedic> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gtzabari, jglick, markiewb, mmirilovic |
| Priority: | P2 | Keywords: | 8.0_WAIVER_APPROVED |
| Version: | 7.4 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | 245348 | ||
| Bug Blocks: | 165451, 230832, 239609, 241883, 241969, 242152, 243035, 244170, 244174, 245103, 245318 | ||
As noted in issue #237072 comment #22, I have seen a class annotation get deleted during Introduce Comment, so this may not be limited to comments. The "Add Constructor" hint deletes the class Javadoc as of build 201401270001. Should I file a separate bug report or will you fix it as part of this issue? Ugh. Guys, we've been experiencing data loss due to this bug for over 2 releases now. If you avoid fixing it for 8.0, then please please please make it a must-fix in the subsequent release. Adapted to API changes introduced by issue #245348 in jet-main#dc9a3b874239 Integrated into 'main-silver', will be available in build *201407170001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/dc9a3b874239 User: Svata Dedic <sdedic@netbeans.org> Log: #239487: code adapted to API change introduced by #245348 |
see discussion in issue #237072; currently one must use GeneratorUtilities to import comments, then manually copy comments from Trees being replaced to new trees. To improve behaviour in hints, comments should be imported automatically for HintContext.getPath() subtree (if the hint modifies something else, it still needs to import the other locations). Comments should be automatically copied from a tree being replaced to the replacement ("comments should not disappear"). There should be a way how to 'alias' nodes which are not directly replaced, to indicate the node is a transformed original one. This is stronger than just copying the source comments to the target as it allows the infrastructure to also collect comments from the obsolete subtree and preserve them in the source. All the above will allow not to loose comments.