Bug 235203

Petr, is default datasource support P2 issue yet after resoleve of additional issues?

In case any hardcoding would happen I think the right place is GF plugin. As other EE servers may differ in particular IDE-required things. We may generalize any time later.

It's not clear yet in https://blogs.oracle.com/arungupta/entry/default_datasource_in_java_ee why it was decided default ee7 is binded to jdbc/__default, even if it is. Also it's a question if binding can be changed or not for gf4. It may affect if we can hardcode on nb side or not. Also it's not clear how gf4 will work with removed jdbc/__default, is there any fake "null" datasource to bind in this case. I may need to try some usecases if nobody know.

> Petr, is default datasource support P2 issue yet after resoleve 
> of additional issues?

I think not, now it's P3 - of course it would still be good to address for 7.4. But now I think it's more important to fix issue 235026 than issue 234729.

> In case any hardcoding would happen I think the right place is GF plugin.

But then, the "getDefaultEE7Datasource" (or similar) method would also need to be added to server integration API, no? Isn't that too complicated especially if we are considering to fix this for 7.4? I would say that since GF 4 is the only EE 7 compliant server right now, as a hotfix for 7.4 it is ok to also hardcode on the Persistence side, if it will make things easier.

Then we should think about the correct way to fix this, and file an extra issue for fixing properly in 8.0 (which is when we may support additional EE 7 servers like Tomcat 8 or TomEE version built on top of Tomcat 8).

(In reply to Petr Jiricka from comment #5)
> > In case any hardcoding would happen I think the right place is GF plugin.
> 
> But then, the "getDefaultEE7Datasource" (or similar) method would also need
> to be added to server integration API, no?
In case of a special method, yes. I supposed this can be returned as a standard DS from DataSourceManager.getDataSources() unless there is special handling needed.

Well, I can return one more data source named comp/DefaultDataSource and connect it with existing DerbyPool connection pool used for jdbc/__default.

This should be easily done with new asadmin code I finished yesterday - I have data source and pools in separate objects linked together and data soiurce entity covers Datasource interface.

Unfortunately old domain.xml reader code has everything mixed together. But I'll make some temporary hack there. I'll rewrite it in better way after code freeze.

it may be a good option, I still may need to hardcode something to consider this one as default in case if no datasources is specified in persistence.xml but it seems reasonale solution.

Checled into web-main:
----------------------
changeset:   262562:bf12a17a8265
summary:     #235203 - Default Java EE 7 resource (comp/DefaultDataSource) clonned from jdbc/__default. Easy hack for 7.4.

This should resolve problem for 7.4. But I don't think it's a final solution. Check http://download.oracle.com/otndocs/jcp/java_ee-7-pr-spec/index.html
In chapter EE.5.20 this is described as common Java EE 7 behaviour and nothing says that it shall be deployed as regular DataSource.

It just says that comp/DefaultDataSource shall be mapped to something that exists in the server. In case of Glassfish it's jdbc/__default.
In the future (next release) I would like to remove 262562:bf12a17a8265 changeset. DatasourceManager#getDatasources() methods should provide reality - list of data sources deployed on server. Not fake ones like comp/DefaultDataSource which are just application level aliases.

But if there is a strong argument to include those aliases, DatasourceManager can be extended to return aliases mapping for any Java EE compliant server.

Something like
/**
 * Retrieve data sources aliases mapping for the server.
 *
 * @return Data source aliases JNDI names mapped to physical dData sources JNDI names deployed on server.
 */
public Map<String, String> getDatasourceAliases();

For GF v4 if will return comp/DefaultDataSource -> jdbc/__default.

Integrated into 'main-silver', will be available in build *201308300001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/bf12a17a8265
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #235203 - Default Java EE 7 resource (comp/DefaultDataSource) clonned from jdbc/__default. Easy hack for 7.4.

So Tomas, are you leaving this open for 8.0 on purpose?

ds should be "java:comp/DefaultDataSource" instead of "comp/DefaultDataSource"

We can do it in better way for next release. This is not problem of GlassFish only.

Checled into web-main:
----------------------
changeset:   262649:a06559f9f7d7
summary:     #235203 - Fixed JNDI name of Java EE 7 resource DefaultDataSource

Integrated into 'main-silver', will be available in build *201308310001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a06559f9f7d7
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #235203 - Fixed JNDI name of Java EE 7 resource DefaultDataSource

the issue related to  the ds implementation on gf side https://java.net/projects/glassfish/lists/issues/archive/2012-12/message/355

may provide some hint on what is this default ds and may be what we can do on nb side. but I can't find sources.

I don't think there is anything to add unless there is a case where the IDE needs to distinct the default DS from the ordinary one.