This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Allow to ignore duplicate exception | ||
|---|---|---|---|
| Product: | platform | Reporter: | František Mantlík <mantlik> |
| Component: | Module System | Assignee: | Jaroslav Tulach <jtulach> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | apireviews, musilt2 |
| Priority: | P1 | Keywords: | API_REVIEW_FAST |
| Version: | 7.4 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 219939 | ||
| Attachments: |
Patch to ignore duplicate exception
The sample application which demonstrates the duplicate exception problem Patch to ignore duplicate exception (updated) |
||
The property would have to be documented according to API review guidelines: http://wiki.netbeans.org/APIReviews Anyway I am not convinced this is the right solution. Please attach sample application that shows your problem. Created attachment 136817 [details] The sample application which demonstrates the duplicate exception problem Dear Jaroslav, thank you for your quick response. The proposed patch is not meant as a solution, but as a workaround to avoid duplicate exception report dialog when starting a RCP application for TestNG functional testing. Attached find a simple application which demonstrates the problem. It is the maven RCP application created by the Netbeans Maven Application wizard. The Junit functional test in the application module is replaced by it's TestNG equivalent created with the use of the TextNG Test Case wizard and extended with simple Jemmy code to demonstrate that functional tests are working. The NetbeansRuntimeContainer class proposed in the Bug 219939 is used to setup and tear down the tested RCP application. It is derived from the NbJunit module. Jellytools and Jemmy in combination with TestNG tests do not need to wrap the tests into the runtime container like in case of Junit tests. It is enough to run the application before the individual tests from the same class loader and stop it when all tests are finished. Everything works fine with one exception, bootstrap process of the tested application complains about dual loading of several modules. I think that this is caused by the classloader constructed by the maven surefire plugin (or better failsafe plugin for safe application shut down when tests fail - not implemented in the presented example) which causes conflicts for several core application modules. Created attachment 137682 [details]
Patch to ignore duplicate exception (updated)
In the updated patch apichanges.xml and arch.xml were updated with corresponding documentation.
Module specification version was increased.
Sending for review. As far as I can tell, the patch looks good and I am ready to integrate it. Just I prefer use of Boolean.getBoolean("...."), so I will likely use that method.
changeset: afee5adee91f tag: tip user: Jaroslav Tulach <jtulach@netbeans.org> date: Wed Jul 31 10:58:04 2013 +0200 summary: #232229: A way to ignore duplicated module. Contributed by mantlik@netbeans.org - thanks. Integrated into 'main-silver', will be available in build *201308072300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/afee5adee91f User: Jaroslav Tulach <jtulach@netbeans.org> Log: #232229: A way to ignore duplicated module. Contributed by mantlik@netbeans.org - thanks. |
Created attachment 136679 [details] Patch to ignore duplicate exception Bunch of DuplicateExceptions is thrown when trying to start TestNG functional tests for a Maven RCP application. The exceptions are most probably harmless, they do not influence tests or tested application, but they pop up an exception reporting dialog. Proposed patch introduces system property "netbeans.ignore.dupmodule". When set to "true", duplicate module is processed normally and a warning is logged: --- o.n.bootstrap/src/org/netbeans/ModuleManager.java +++ o.n.bootstrap/src/org/netbeans/ModuleManager.java @@ -892,8 +892,12 @@ private void subCreate(Module m) throws DuplicateException { Module old = get(m.getCodeNameBase()); if (old != null) { + if (System.getProperty("netbeans.ignore.dupmodule", "false").equalsIgnoreCase("false")) { throw new DuplicateException(old, m); + } else { + Util.err.warning("Duplicate loading ignored: " + old + " and " + m); } + } modules.add(m); modulesByName.put(m.getCodeNameBase(), m); providersOf.possibleProviderAdded(m);