This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | [Dark Theme] Source code not readable during debugging | ||
|---|---|---|---|
| Product: | debugger | Reporter: | Tomas Mysik <tmysik> |
| Component: | Code | Assignee: | Jan Peska <JPESKA> |
| Status: | RESOLVED INCOMPLETE | ||
| Severity: | normal | CC: | kosmonaffft, markiewb, venkatramakkineni |
| Priority: | P3 | Keywords: | NO74 |
| Version: | 7.4 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | 231735 | ||
| Bug Blocks: | |||
| Attachments: |
screenshot
Shows the color settings in IntelliJ IDEA darcula theme example patch Shows the issue - still in 201402110001 build |
||
The breakpoint and current line annotations need to be darker. I changed it to 84, 112, 71 and it is much better now. Thanks for the hint ;) BTW I have changed color for "Program Counter and a Breakpoint" but it does not work (the color is still same as before although new color is set in IDE Options). Thanks. IDE restart helped... It looks like it's not possible to fix this before issue #231735 is fixed. *** Bug 233166 has been marked as a duplicate of this bug. *** Dark themes were moved to the NetBeans Update Center for NB 7.4 Created attachment 139901 [details]
Shows the color settings in IntelliJ IDEA darcula theme
You could use the same colors as IntelliJ IDEA darcula theme uses:
Breakpoint line: rgb(58 35 35) Dark red
Execution line: rgb(45 96 153) Blue
See screenshot
I know in NetBeans you can define nearly every combination of breakpoint and state like "broken line breakpoint with current execution point". This is overkill IMHO. Breakpoint line should be "dark red". Combinations which include the current execution line should be "blue". Nothing more.
@Martin: What do you think?
Thanks for the hints, but unfortunately I can not do anything in this area, until issue #231735 is fixed. *** Bug 205410 has been marked as a duplicate of this bug. *** The dark theme will be soon very cool and complete. IMHO, I just miss this one. Regards. it seems that fix of issue #231735 does not allow to add a default value for different editor profiles (in this case Norway Today). I've added new xml file into to the defaults module (BlueTheme-annotations.xml) with new color value of the breakpoint but the default value is unchanged (tried with empty userdir). I'm reassigning the issue to Editor. Mito, can you please take a look? Thanks I forgot to tell you that you need to register file to layer.xml. Created attachment 144743 [details]
example patch
Here is an example, and it works.
Integrated into 'main-silver', will be available in build *201402070001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/91268b4c3651 User: Jan Peska <JPESKA@netbeans.org> Log: Issue #231617 - [Dark Theme] Source code not readable during debugging Adjust background colors for Norway Today (In reply to Quality Engineering from comment #16) > Integrated into 'main-silver', will be available in build *201402070001* on > http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) > > Changeset: http://hg.netbeans.org/main-silver/rev/91268b4c3651 > User: Jan Peska <JPESKA@netbeans.org> > Log: Issue #231617 - [Dark Theme] Source code not readable during debugging > Adjust background colors for Norway Today Reopen. Disabled breakpoints are still white on gray background and white on green background. See screenshot Product Version: NetBeans IDE Dev (Build 201402110001) Java: 1.7.0_45; Java HotSpot(TM) 64-Bit Server VM 24.45-b08 Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18 System: Windows 7 version 6.1 running on amd64; Cp1252; de_DE (nb) Created attachment 145039 [details]
Shows the issue - still in 201402110001 build
fix: http://hg.netbeans.org/core-main/rev/bb5883cc54f9 I've changed also color for disabled breakpoint but I've noticed with new userdir all changed colors are ignored by editor - in options they are set to the right values but editor ignores them and uses the default ones. To workaround this issue you have to click "Restore" button and reopen editor window. I'll file new bug to editor team since the color setup is fixed. Jan, Is there another bug out there for this issue ? Could you please attach it here ? (In reply to Jan Peska from comment #19) > fix: http://hg.netbeans.org/core-main/rev/bb5883cc54f9 > > I've changed also color for disabled breakpoint but I've noticed with new > userdir all changed colors are ignored by editor - in options they are set > to the right values but editor ignores them and uses the default ones. To > workaround this issue you have to click "Restore" button and reopen editor > window. I'll file new bug to editor team since the color setup is fixed. This bug has resurfaced in 8.2 |
Created attachment 136126 [details] screenshot Have a look at the screenshot. Thanks. Product Version: NetBeans IDE 7.4 Beta (Build 20130617-a607f6dd7537) Java: 1.7.0_25; Java HotSpot(TM) 64-Bit Server VM 23.25-b01 Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b15 System: Linux version 3.8.0-25-generic running on amd64; UTF-8; cs_CZ (nb)