This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | SQLIdentifiers.Quoter does not correctly quote identifiers containing the quote character itself | ||
---|---|---|---|
Product: | db | Reporter: | ebakke |
Component: | Code | Assignee: | Jaroslav Havlin <jhavlin> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | NETFIX |
Priority: | P3 | ||
Version: | 7.2.1 | ||
Hardware: | PC | ||
OS: | Mac OS X | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
proposed patch v1 part 1
proposed patch v1 part 2 |
Description
ebakke
2013-01-18 23:14:12 UTC
Created attachment 130405 [details]
proposed patch v1 part 1
The diagnosis is correct and reproducible. The first attached patch fixes this and adds a unit-test for this.
Created attachment 130406 [details]
proposed patch v1 part 2
Part 2 of the patch - the lexer did not correctly worked with identifier quoting characters other than ". The patch includes a modified unit-test.
Thanks--I'm impressed by the swift response :-) (I take back my earlier suggestion that DatabaseMetaDataQuoter.needToQuote() needed to be changed--the patch looks good.) Integrated as http://hg.netbeans.org/core-main/rev/2faf2562a671 Thank you very much for reporting, Ebakke, and for the patch, Matthias! Integrated into 'main-golden', will be available in build *201302092300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/2faf2562a671 User: Jaroslav Havlin <jhavlin@netbeans.org> Log: #225079: SQLIdentifiers.Quoter does not correctly quote identifiers containing the quote character itself |