This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220401

Summary:	No possibility to remove the "AcceptAll FileFilter" via FileChooserBuilder
Product:	utilities	Reporter:	Tomas Mysik <tmysik>
Component:	Open File	Assignee:	Tomas Mysik <tmysik>
Status:	RESOLVED FIXED
Severity:	normal	CC:	apireviews, jhavlin, jtulach
Priority:	P3	Keywords:	API, API_REVIEW_FAST
Version:	7.3
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	216141
Attachments:	API change

Description Tomas Mysik 2012-10-19 07:55:52 UTC

To fix issue #216141, I need to be able to remove the default "All Files" filter but this is currently not possible via the FileChooserBuilder class. This is also the reason why I am filing it a defect and not as an enhancement.

I know that I could simply createFileChooser() and then remove the filter but if one looks at the showOpenDialog() method, it is clear that this method should be called (to correctly open the native file chooser etc.). Moreover, this API change is very small.

Thanks, I will attach a patch.

Comment 1 Tomas Mysik 2012-10-19 07:57:35 UTC

Created attachment 126175 [details]
API change

Proposed fix

Comment 2 Tomas Mysik 2012-10-19 07:59:52 UTC

Please review. Jardo, feel free to assign to me if you think that the patch is OK.

Thanks.

Comment 3 Tomas Mysik 2012-10-19 08:36:59 UTC

Adding Jarda Tulach to CC since the change is in fact in the FS module.

Thanks.

Comment 4 Tomas Mysik 2012-10-19 08:37:26 UTC

Also assigning to myself.

Comment 5 Jaroslav Havlin 2012-10-19 08:38:49 UTC

I think that the patch is OK.
Thank you, Tomas.

Comment 6 Jaroslav Tulach 2012-10-19 13:13:50 UTC

Seems OK to me.

Comment 7 Tomas Mysik 2012-10-30 09:29:04 UTC

Fixed. Thanks for the review.

http://hg.netbeans.org/web-main/rev/fc649a0fde3e

Comment 8 Quality Engineering 2012-10-31 02:57:39 UTC

Integrated into 'main-golden', will be available in build *201210310001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/fc649a0fde3e
User: Tomas Mysik <tmysik@netbeans.org>
Log: #220401 - No possibility to remove the "AcceptAll FileFilter" via FileChooserBuilder