This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 218422

Summary:	The Implmenentation-Version manifest attribute should not be set to constant "1.0"
Product:	javafx	Reporter:	stargater
Component:	Deployment	Assignee:	Petr Somol <psomol>
Status:	RESOLVED FIXED
Severity:	normal	CC:	neigor, psomol
Priority:	P3	Keywords:	API_REVIEW_FAST
Version:	7.2
Hardware:	PC
OS:	Windows 7
Issue Type:	ENHANCEMENT	Exception Reporter:
Bug Depends on:
Bug Blocks:	204758
Attachments:	api change + patch resolving this issue

Description stargater 2012-09-16 17:25:13 UTC

The "deploy-jar" macrodef in jfx-impl.xml generates the manifest file with attribute "Implementation-Version=1.0"
It could get the value from e.g. project properties just like the "Implementation-Vendor" attribute.

Comment 1 Petr Somol 2013-03-12 16:53:46 UTC

Created attachment 132526 [details]
api change + patch resolving this issue

Surfacing version info appears to fit best to Application panel in Project Properties dialog. In FX project the UI change would involve adding an extension panel to the standard SE Application panel using J2SECategoryExtensionProvider. To enable this the J2SECategoryExtensionProvider permissions need to be extended. Thi API change is trivial and has no side effects:

-    enum ExtensibleCategory { PACKAGING, RUN }
+    enum ExtensibleCategory { PACKAGING, RUN, APPLICATION }

Attaching a patch with the api change + code resolving this issue

Comment 2 Petr Somol 2013-03-21 14:22:24 UTC

no comments during the last week, going to integrate

Comment 3 Petr Somol 2013-03-21 15:55:43 UTC

fixed in jetmain
http://hg.netbeans.org/jet-main/rev/f275fa3dca7a

Comment 4 Petr Somol 2013-03-21 16:00:41 UTC

Remark: Implementation version can now be specified in Project Properties->Application panel. It is passed to jar manifest but also to native packager where it is used at least for naming installer files.

Comment 5 Quality Engineering 2013-03-24 01:53:38 UTC

Integrated into 'main-golden', will be available in build *201303232300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/f275fa3dca7a
User: Petr Somol <psomol@netbeans.org>
Log: #218422 - The Implmenentation-Version manifest attribute should not be set to constant 1.0