This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 217978

Summary:	Failing testWriteAccess
Product:	editor	Reporter:	Jiri Skrivanek <jskrivanek>
Component:	Options	Assignee:	Jan Lahoda <jlahoda>
Status:	VERIFIED FIXED
Severity:	normal	CC:	apireviews, cyhelsky, jlahoda, jtulach
Priority:	P1	Keywords:	API, API_REVIEW_FAST, TEST
Version:	7.3
Hardware:	PC
OS:	Windows 7
Issue Type:	DEFECT	Exception Reporter:
Attachments:	Api change

Description Jiri Skrivanek 2012-09-07 09:13:33 UTC

Please, evaluate testWriteAccess failures:

http://hudson4qe.cz.oracle.com/view/Trunk-QE/job/CV-multi-UI/615/jdk=JDK%207,label=ubuntu/testReport/org.netbeans.test.ide/IDECommitValidationTest/testWriteAccess/?

 ant -f java.kit test-qa-functional -Dtest.includes=**/IDECommitValidationTest*

Comment 1 Milutin Kristofic 2012-09-11 11:25:32 UTC

I suspect prefs.putBoolean("enable.breadcrumbs", true) at org.netbeans.modules.editor.EditorModule.restored(EditorModule.java:274)

Comment 2 Jan Lahoda 2012-09-11 12:20:26 UTC

Created attachment 124161 [details]
Api change

Comment 3 Jan Lahoda 2012-09-11 12:20:56 UTC

Please review.

Comment 4 Jan Lahoda 2012-09-11 12:41:10 UTC

*** Bug 217794 has been marked as a duplicate of this bug. ***

Comment 5 Jaroslav Tulach 2012-09-12 12:20:20 UTC

As far as the actual API review goes - I have nothing to add.

On a general note I am surprised breadcrums talk to editor.lib2 via non-public API. I lived under the assumption editor.lib2 is an official API replacement over editor.lib and thus I'd expect the exposes enough functionality for people using editor to eliminate use of editor.lib as well as implementation dependencies.

Comment 6 Quality Engineering 2012-09-19 03:04:25 UTC

Integrated into 'main-golden', will be available in build *201209190001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/626193f7bb4e
User: Jan Lahoda <jlahoda@netbeans.org>
Log: #217978: enable breadcrumbs through defining a default for AlwaysEnabledAction rather then by setting it enabled

Comment 7 Jan Lahoda 2012-09-19 07:58:32 UTC

Thanks for the review, integrated.