This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Make extexecution lightweight | ||
|---|---|---|---|
| Product: | platform | Reporter: | Petr Hejl <phejl> |
| Component: | Execution | Assignee: | Petr Hejl <phejl> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | akrasny, apireviews, jtulach |
| Priority: | P1 | Keywords: | API, API_REVIEW_FAST |
| Version: | 7.3 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 199812 | ||
| Attachments: |
the patch
fixed patch patch with a test patch with a test |
||
|
Description
Petr Hejl
2012-08-14 20:53:21 UTC
Created attachment 123118 [details]
the patch
Attaching the patch making extexecution lightweight.
Please review. BTW With this patch all dependencies of extexecution are in platform cluster so if somebody would be interested in pushing it down to platform it would be possible. Created attachment 123127 [details]
fixed patch
I've noticed there are 3 implementation files missing in the previous patch - fixed in this one.
Created attachment 123132 [details]
patch with a test
Added test.
Created attachment 123133 [details]
patch with a test
Readding and making old patches obsolete.
Nice. Only one comment: Y01 Currently the provides/recommends wiring is using a single token although there are separate three interfaces being requested. This basically implies that all the implementations should be in the same module. A more flexible design would provide/recommend one token per interface. (In reply to comment #7) > Nice. Only one comment: > > Y01 Currently the provides/recommends wiring is using a single token although > there are separate three interfaces being requested. This basically implies > that all the implementations should be in the same module. A more flexible > design would provide/recommend one token per interface. I was thinking about that and my reasoning was that the other two things has reasonable default implementation while missing OptionOpenHandler causes kind of missing functionality (no option button and warning in the log). So I choose only this one as a token. Do you think I should add File and Http handlers as well? No problem with that. I do not have a strong opinion about this. FYI I have pushed the current patch as: changeset: 229893:bb87ed1ecd16 branch: extexecution-split tag: tip user: Petr Hejl <phejl@netbeans.org> date: Wed Aug 15 12:42:22 2012 +0200 summary: #216882 Make extexecution lightweight I'll keep the issue open at least for a week and integrate possible suggestions to the branch. There does not seem to be any controversy about this patch. I'll merge the change on Monday. Y01 fixed: changeset: 230571:348f80a879bf branch: extexecution-split tag: tip user: Petr Hejl <phejl@netbeans.org> date: Wed Aug 22 15:55:00 2012 +0200 summary: #216882 - Make extexecution lightweight Merged to trunk 52a25242e523. Thanks for the review. Integrated into 'main-golden', will be available in build *201208280001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/bb87ed1ecd16 User: Petr Hejl <phejl@netbeans.org> Log: #216882 Make extexecution lightweight |