This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Enhance ErrorDescription(Factory) with optional ID and more details text | ||
|---|---|---|---|
| Product: | editor | Reporter: | Jan Lahoda <jlahoda> |
| Component: | Hints & Annotations | Assignee: | Milutin Kristofic <mkristofic> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | apireviews, jglick |
| Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
| Version: | 7.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Attachments: | Proposed API change. | ||
|
Description
Jan Lahoda
2012-03-12 08:43:28 UTC
Created attachment 116594 [details]
Proposed API change.
Please review. Thanks. The patch is OK. [JG01] The createErrorDescription overloads are becoming unreadably long. Consider using the builder pattern for optional args, e.g.
ErrorDescription e = ErrorDescriptionFactory.make(WARNING, "Bad stuff!", doc, line).id("bad_stuff).details("There is bad stuff here.").fixes(oneFix, anotherFix);
JL01: I am thinking about converting the factory into a builder (possibly deprecating the whole ErrorDescriptionFactory and replacing it with ErrorDescriptionBuilder), but I would rather keep the change simple for now. If/when we move to to the builder pattern, deprecating three additional methods shouldn't be too difficult. JG01 - OK. This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue. Thanks for your cooperation, NetBeans IDE 8.2 Release Boss |