This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | @DataObject.Registrations | ||
|---|---|---|---|
| Product: | platform | Reporter: | skygo <skygo> |
| Component: | Data Systems | Assignee: | Jaroslav Tulach <jtulach> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | apireviews, jglick |
| Priority: | P2 | Keywords: | API_REVIEW_FAST |
| Version: | 7.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 207219, 208394 | ||
| Attachments: |
@DataObject.Registrations api, processor, test
@DataObject.Registrations api, processor, test with mimeType as String |
||
[JG01] Should make mimeType be of type String, not String[] - there should not be two ways of doing one thing. (In reply to comment #1) [JG01] It will lead to more line for registration in some case, but I'am fine with restricting to String. To handle this I need to know what to do with apichange. As netbeans 7.2 is not out is it fine to keep 7.36 version which is the version introducting the issue #207219 ? Let's keep 7.36 and update it to mention there is Registrations as well since then. Created attachment 116085 [details]
@DataObject.Registrations api, processor, test with mimeType as String
According to
JG01
Change mimeType String[] to simple String
Unit Test changed accordingly
ApiChange patched still in 7.36
I've put the code on branch http://hg.netbeans.org/core-main/rev/DataObjectRegistrations-208670 and I'd like to integrate tomorrow, if there are no objections. I do not think you want DoFPDataObjectMultiple and DoFPDataObject to both use position = 3565, or there will be warnings in unit tests. (In reply to comment #6) > I do not think you want DoFPDataObjectMultiple and DoFPDataObject to both use > position = 3565, or there will be warnings in unit tests. mimetype is different "text/test1" vs "text/testm1". Maybe I should use more different name to avoid confusion. (In reply to comment #7) > mimetype is different "text/test1" vs "text/testm1". OK, in that case o.o.filesystems.Ordering should issue no warnings I think. Merged as core-main#e1113a819b22 |
Created attachment 115967 [details] @DataObject.Registrations api, processor, test Hi this is a continuation of issue #207219, this patch is for the possibility of having multiple dataobject registration on the same class allowing customisation per mimetype. As this addition is in strenght relation with 207219 I keep 7.36 version for this. This is blocking potential refactoring of image module and maybe other one. Wihtout this patch you must merge displayName @DO.Registration{mimetype={"image/gif","image/png},displayName="... file") This patch should allow something like this (rough code) @DO.Registrations( @DO.Registration{mimetype={"image/png","image/pneg"},displayName="PNG file"), @DO.Registration{mimetype="image/gif",displayName="GIF file") )