This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | ScanUtils background scan - aware support | ||
---|---|---|---|
Product: | java | Reporter: | Svata Dedic <sdedic> |
Component: | Source | Assignee: | Svata Dedic <sdedic> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | apireviews, dkonecny, marfous, sdedic |
Priority: | P3 | Keywords: | API_REVIEW |
Version: | 7.2 | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Svata Dedic
2012-01-25 08:12:11 UTC
Thanks Svata. I only looked at the helper methods provided and that looks good. I would suggest to rename "mayBecomeCompleted" into something like "isElementBeingScanned". Incorporated review items from Dusan & Lahvac. * wrapper resolve/find methods should be removed * isElementUsable should move as isErroneous() to ElementUtilities * methods should work with CompilationInfo rather than with JavaSource * variant methods added, which work with Source and Parsing API rather than JavaSource * exception handling cleaned up and unified with Parsing API / Java parser Seems good to me. Integrated in jet-main #94fc0582b286 |