This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | API Review for Move Members Refactoring | ||
|---|---|---|---|
| Product: | java | Reporter: | Ralph Ruijs <ralphbenjamin> |
| Component: | Refactoring | Assignee: | Ralph Ruijs <ralphbenjamin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | apireviews, jbecicka, jglick, ralphbenjamin |
| Priority: | P2 | Keywords: | API, API_REVIEW_FAST |
| Version: | 7.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 204441, 204442 | ||
| Attachments: |
Proposed patch
Proposed patch |
||
|
Description
Ralph Ruijs
2011-11-30 09:14:30 UTC
Created attachment 113651 [details]
Proposed patch
MoveRefactoring should stay final. We don't want API clients to subclass it and let them change behavior. Moreover we don't want existing "move" plugins to participate on this new functionality, since it will probably not work. The only functionality of MoveRefactoring you need is set/get target. I suggest to create a new final API class MoveMembersRefactoring in refactoring.java module. Created attachment 113811 [details]
Proposed patch
I changed the patch to the same situation we have in JavaRename.
please attach complete API change. I don't know what do you mean by "JavaRename" (In reply to comment #4) > please attach complete API change. I don't know what do you mean by > "JavaRename" The attached patch is the complete API change. I was referring to the usage of org.netbeans.modules.refactoring.java.ui.JavaRenameProperties. I see! Now I understand. The patch looks good. Unrelated, but Y01: Fix broken links in your API. I am sure "{@link org.openide.filsuystems.FileObject}" leads nowhere.
(In reply to comment #7) > Unrelated, but Y01: Fix broken links in your API. I am sure "{@link > org.openide.filsuystems.FileObject}" leads nowhere. Y01: Thanks! Fixed in jet-main 872ee1c00ba4 & 3df75cdbdfe2 Fixed in jet-main. http://hg.netbeans.org/jet-main/rev/eeef4c477645 Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/eeef4c477645 User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org> Log: Issue #205696 - API Review for Move Members Refactoring The date recorded in apichanges is Nov 30 '11, which is obviously wrong. (In reply to comment #11) > The date recorded in apichanges is Nov 30 '11, which is obviously wrong. Thanks, I forgot to change the date when committing the change. http://hg.netbeans.org/jet-main/rev/85116f41dc33 |