Bug 204089

Created attachment 112321 [details]
Testcase in zip file

Created attachment 112322 [details]
log files before copy

Created attachment 112323 [details]
log files after copy

*** Bug 201324 has been marked as a duplicate of this bug. ***

I am not able to reproduce it.
The logged exception are only log should not affect functionality. Anyway I've rewritten the TreeRootNode not to cause them.
jet-main 002c73ed1b13

Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/002c73ed1b13
User: Tomas Zezula <tzezula@netbeans.org>
Log: #204089:Cannot copy Java Package from one Project to another

In my case, it still reproduces in the latest dev build.

Product Version: NetBeans IDE Dev (Build 201111040600)

It looks like I am hitting a frequently occurring issue now:

NullPointerException
NetBeans Error Report Upload Complete
It has now been added to the database with id #539839. It has been classified as a duplicate of report #23304.
This bug was already resolved.
You can check bug #126271 in Bugzilla for more information.

Created attachment 112873 [details]
log file after copy

Works for me.
Even in the log there is no exception (or anything else) regarding the copy operation.

The:
java.lang.NullPointerException
	at com.sun.tools.javac.comp.Flow.visitMethodDef(Flow.java:775)
	at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:674)

comes from different thread and has no effect on copy.

I've retested with a full build again following exactly the steps (Start GlassFish server in debug mode (this might not be required but I did it) and Undeploy all applications (this might not be required but I did it)) and works fine all files were copied.

I reproduced this twice on the first two attempts with a new, much faster computer in a completely different environment where I started fresh with downloading all files from the net including the testcase. There seems to be a new bug where the lib jars in the attached projects cannot be found. I added only one jar file in the fix dialog on opening the testcase and it fixed itself. You may have to do this as well until NetBeans is happy with the libraries - except the missing class org.apache.util.convert.IConverter.

Here are the slightly modified steps that I recorded again:

How to reproduce:

- Open NetBeans with new userdir without importing settings.
- Open Maven project apache-wicket-1.5.1\src\wicket-examples provided with the wicket distribution downloaded from http://wicket.apache.org/
- Start GlassFish server in debug mode (this might not be required but I did it).
- Undeploy all applications (this might not be required but I did it).
- Menu|Tools|Options|Files|Uncheck Enable auto-scanning of sources
- Menu|Tools|Options|Miscellaneous|Maven|Globale Execution Options, add --fail-never
- Run Maven project with GlassFish 3.1 (this might not be required but I did it).
- No server selected, select GlassFish 3.1, check Remember Permanently
- Open attached project CopyTest
At this stage, the project does not compile, because org.apache.util.convert.IConverter is not found. As part of the test, don't fix that. In fact, NetBeans earlier failed to indicate that this class was missing.
At least one exception is shown in the log already.
- Projects Window|Right click|View packages as tree
- In CopyTest project, create package org.apache.wicket.examples by copying and pasting the complete package name including dots at once (already done).
- In the Projects window, in the Maven project, select the package forminput and copy it
- In the Projects window, in the CopyTest project, select the package org.apache.wicket.examples and paste.

An exception occurs and the copy operation copied only the first four files:
- BeforeAndAfterBorder.html
- BeforeAndAfterBorder.java
- FormInput.html
- FormInput.java

May be this helps to reproduce this - id doesn't do any harm before running the test:

in apache-wicket-1.5.1\src
run mvn -Dmaven.test.skip=true

Do I understand correctly, that I need to run:

in apache-wicket-1.5.1\src
run mvn -Dmaven.test.skip=true

to reproduce the problem?
Without running this the copy works fine, right?

I can't say that it is really necessary. I am just trying to think what could help. Re your first question, I have not been able to run the testcase successfully even once following the steps on this page.

In similar scenarios where the same library was missing (and later other libraries), but without even trying to copy files, I got NullPointerExceptions today that I reported with the Exception Reporter. I think this is a very interesting case, possibly quite rewarding to solve. Other problems will disappear with it.

This is a very common scenario where a project is copied without libraries and the developer is gradually adding the libraries until the project no longer breaks. I always get these errors with NetBeans when I do this.

Sorry, still works fine for me even when doing all the steps (including starting GF in debug mode, undeploy). All files were copied to CopyTest project.

No exception is thrown (even the NPE from Flow.visitMethodDef is not thrown, but it is harmless for the copy operation). Can you verify that the files are really not copied on disk? That it's not just UI refresh problem.
Thanks

Created attachment 113314 [details]
Patch file with logging

Created attachment 113315 [details]
Patched module with logging

Please can you try to reproduce the problem with applied patch containing the logging.
If you build the IDE from source apply the Patch file before build. If you are using builds download a night build and replace the netbeans/platform/modules/org-openide-loaders.jar with the Patched module.
Then start the IDE with the following command line option:

-J-Dorg.openide.loaders.DataFolder.level=FINE

do the copy of the forminput folder and attach the log file.
Thanks

The Tree View is just a FilterNode on top of the FolderNode, the copy operation is handled by FN.
Without logging from reporter it's hard to say why the files were not copied.

Jirko, can you try it on Windows? To verify that it's not Windows specific issue, I am not able to reproduce it on UNIX.

I was going to ask whether Windows was actually tried. I have reproduced it multiple times on different computers, Windows 2000 and Windows XP.

I can reate any number of testcases such as this one - these problems are dead easy to reproduce. But the creation of the testcases from production code takes days with many generations of successive removal of detail.

I would prefer that a few more people try to reproduce this on Windows. I am running out of time - I don't have the resources now to build the IDE for the logging. Please don't mark this as incomplete. This is as complete as it can get.

BTW I am changing to priority 1 because of data loss.

I have just tried (several times) on a Windows 7 machine. Unfortunately we are not able to reproduce this - closing as "works for me".

Mariane and Co.: If someone is able to reproduce so we can debug it please reopen.

I am still not able to reproduce, but I've think that I probably found what can be the problem.

Fixed jet-main 0edc81c2aa11

The fix seems to be ok


Product Version: NetBeans IDE Dev (Build 20111122-9a8edc0fe2de)
Java: 1.7.0_02; Java HotSpot(TM) 64-Bit Server VM 22.0-b10
System: Windows 7 version 6.1 running on amd64; Cp1250; en_US (nb)
User directory: C:\Users\jprox\.netbeans\dev
Cache directory: C:\Users\jprox\.netbeans\dev\var\cache

Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/0edc81c2aa11
User: Tomas Zezula <tzezula@netbeans.org>
Log: #204089:Cannot copy Java Package from one Project to another

Patch is OK.

integrated into 7.1 f7b0d1285982

Integrated into 'releases'
Changeset: http://hg.netbeans.org/releases/rev/f7b0d1285982
User: Tomas Zezula <tzezula@netbeans.org>
Log: #204089:Cannot copy Java Package from one Project to another

verified