This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199452

Summary:	add support for window layout roles to TopComponent registration annotation
Product:	platform	Reporter:	Stanislav Aubrecht <saubrecht>
Component:	Window System	Assignee:	Stanislav Aubrecht <saubrecht>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jglick
Priority:	P2	Keywords:	API, API_REVIEW_FAST
Version:	7.1
Hardware:	All
OS:	All
Issue Type:	ENHANCEMENT	Exception Reporter:
Bug Depends on:	203553
Bug Blocks:
Attachments:	proposed patch & api changes

Description Stanislav Aubrecht 2011-06-16 09:22:13 UTC

support for multiple window layouts has been introduced into the window system recently (issue #198856)

the annotation for TopComponent registration should be extended to allow the specification of the role the window should belong to.

Comment 1 Stanislav Aubrecht 2011-06-16 09:40:06 UTC

Created attachment 108924 [details]
proposed patch & api changes

Comment 2 Stanislav Aubrecht 2011-06-20 13:20:38 UTC

if there are no objections, i'll integrate the patch tomorrow

Comment 3 Jesse Glick 2011-06-21 18:36:15 UTC

[JG01] This code:

if( role.trim().isEmpty() )
    role = null;
String rootFolder = "Windows2";
if( null != role )
    rootFolder += "/Roles/" + role;

could be simplified to:

String rootFolder = role.isEmpty() ? "Windows2" : "Windows2/Roles/" + role;


[JG02] Add to TopComponentProcessorTest.

Comment 4 Stanislav Aubrecht 2011-06-22 09:04:22 UTC

core-main 322a0a086e28

(with jesse's comments fixed)

Comment 5 Quality Engineering 2011-06-24 14:29:23 UTC

Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/322a0a086e28
User: S. Aubrecht <saubrecht@netbeans.org>
Log: #199452 - support window layout roles in TC registration

Comment 6 Jesse Glick 2011-06-27 19:31:34 UTC

(Version & TM somehow got mangled when closing)