This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | CopyFinder functionality needed in Java Refactoring module. | ||
|---|---|---|---|
| Product: | java | Reporter: | Jan Becicka <jbecicka> |
| Component: | Source | Assignee: | apireviews <apireviews> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jlahoda, ralphbenjamin |
| Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
| Version: | 7.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 176217 | ||
| Attachments: |
SourceUtils.computeDuplicates
2nd version with fixed class loaders added apichanges |
||
|
Description
Jan Becicka
2011-06-02 11:00:42 UTC
Created attachment 110200 [details]
SourceUtils.computeDuplicates
I created utility method in SourceUtils. I'd like to ask Ralph to test it, if this is what he want. I did not create any special test for it, but I changed all occurrences of this method in IntroduceHint to use this new method and all IntroduceTests (142) passed, so I suppose it works. And and like to ask jlahoda to review the impl... Created attachment 110207 [details]
2nd version with fixed class loaders
The method signature seems fine to me. The implementation is of course a terrible hack, but better than any alternative that I can imagine, so I am fine with that too. Might be good to add a comment to the CopyFinderService with a warning that it is used from SourceUtils. Thanks. Thanks, this is what is needed for the Introduce Parameter Refactoring. Created attachment 110236 [details]
added apichanges
Please review SourceUtils.computeDuplicates We know, that impl. is hack, but we can live with it for 7.1 I hope. Changeset: http://hg.netbeans.org/jet-main/rev/fa9fde2aa465 Author: Jan Becicka <jbecicka@netbeans.org> Date: 2011-08-29 13:50 Message: Issue #199106 - CopyFinder functionality needed in Java Refactoring module. Changeset: http://hg.netbeans.org/jet-main/rev/1b655b483c93 Author: Jan Becicka <jbecicka@netbeans.org> Date: 2011-08-29 14:23 Message: Issue #199106 - CopyFinder functionality needed in Java Refactoring module. Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/fa9fde2aa465 User: Jan Becicka <jbecicka@netbeans.org> Log: Issue #199106 - CopyFinder functionality needed in Java Refactoring module. |