This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Entity annotation not separated by a new line | ||
---|---|---|---|
Product: | java | Reporter: | Jiri Skrivanek <jskrivanek> |
Component: | Source | Assignee: | Jan Lahoda <jlahoda> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | debuggercz, dkonecny, jiriprox, jskrivanek, marfous, mmirilovic, muellermi, pjiricka, sj-nb, tzezula |
Priority: | P2 | ||
Version: | 7.0.1 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | possible workaround on persistence side, diff for EntityWizard |
Description
Jiri Skrivanek
2011-04-07 14:33:54 UTC
Entity creation code create class from template and modify it by addition of implements and annotation, if I comment out implements addition code will be generated in two lines. so far I can reproduce the issue with "hg update - d 2011-02-08" and can't with "hg update - d 2011-02-05" Honzo, I've already have fix. one more point, unit tests can't reproduce the issue with the same build as I can reproduce the issue manually. Created attachment 107644 [details]
possible workaround on persistence side, diff for EntityWizard
how is it going? I have a workaround on persistence side but I don't like it as final solution, for example with attached diff for EntityWizard generation produce correct entity, but with second source modification task it's likely will cause performance regression. for entity from db next line is generated "@Entity@Table(name = "PRODUCT_CODE")" Any progress with this? it looks like I have an issue with session bean from entities now too with @Stateless on wrong line and with extra "{", isn't tested on zip distribution yet, but as I'm going to develop in the area now, it makes the issue more severe now. I'm not sure if latest one case is the same as with @Entity. This issue may be related to issue 199881, also it may be related to some issues I report already(or can find later) but reproducible only with my build system and it's hard to debug these issues also. Affects issues with generation sequence with intermediate step to generate entity etc. As I got it the issue affects windows build platform and isn't specific to my build system only. So upgrading to P2. Jiri, can you try if you can reproduce issue 199881 also? (part related to wrong annotation with extra "{") Tomas, could you integrate your fix from august? Now it is reproducible in the latest daily build 201110250600. If I still find it somewhere ;-) *** Bug 204478 has been marked as a duplicate of this bug. *** Any progress? It blocks some our tests almost for month. *** Bug 205111 has been marked as a duplicate of this bug. *** If it's the issue for official builds now, shouldn't it be a showstopper? P1 may be? This should fix the problem: http://hg.netbeans.org/jet-main/rev/6bc3b68f72f3 Jirka S. or Jirka P., could you please verify? Tomas, could you please review the fix? Thanks. The patch is OK. Verified in custom dev 20111122-9a8edc0fe2de. Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/6bc3b68f72f3 User: Jan Lahoda <jlahoda@netbeans.org> Log: #197538: correctly skipping '\r' in '\r\n' even in case only one character is to be read. Integrated into 'releases' Changeset: http://hg.netbeans.org/releases/rev/292e0702176d User: Jan Lahoda <jlahoda@netbeans.org> Log: #197538: correctly skipping '\r' in '\r\n' even in case only one character is to be read. Verified in NetBeans IDE 7.1 RC1 (Build 201111222200). *** Bug 199881 has been marked as a duplicate of this bug. *** |