This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Improve efficiency of HighlightingManager together with View Hierarchy | ||
|---|---|---|---|
| Product: | editor | Reporter: | Miloslav Metelka <mmetelka> |
| Component: | Painting & Printing | Assignee: | Miloslav Metelka <mmetelka> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexvsimon, andrey_pk, bht, dbalek, dds.dhawal, dkonecny, dziastinux, Emperorlou, err, exceptions_reporter, gorrus, hmichel, jamiehutber, jglick, jkovalsky, loqman, mclaborn, michbarsinai, mmirilovic, moonport, muhammadghazali, nb_johan1, pjiricka, revathskumar, sapanparikh18, shmaltorhbooks, Simz, spao001, stac, tmysik, vladimircs, vv159170, xaguilars |
| Priority: | P2 | Keywords: | PERFORMANCE, PLAN |
| Version: | 7.0 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
|
Description
Miloslav Metelka
2011-04-07 12:34:46 UTC
4. Optimize ParagraphView rebuilding process by reusing start position of the corresponding paragraph element where possible. 4. was already implemented by issue #198719. 2. is case by case since OffsetsBag may still be more memory efficient for the highlights. 1. and 3. will be handled by upcoming commit. *** Bug 194816 has been marked as a duplicate of this bug. *** *** Bug 197309 has been marked as a duplicate of this bug. *** *** Bug 197687 has been marked as a duplicate of this bug. *** *** Bug 197892 has been marked as a duplicate of this bug. *** *** Bug 197917 has been marked as a duplicate of this bug. *** *** Bug 198561 has been marked as a duplicate of this bug. *** Unfortunately I'm still facing regressions with the rewritten code :( It's not stable enough for integration so I have to ask for a waiver for 7.0.1. I hope to stabilize and integrate the new code into the trunk during the next week. (In reply to comment #9) > Unfortunately I'm still facing regressions with the rewritten code :( > It's not stable enough for integration so I have to ask for a waiver for 7.0.1. I agree, the only small note I would add to this : we will run community testing next two weeks for NB 7.0.1, in case we will face plenty reports i would vote for additional try to fix this into 7.0.1 , if not I am fine to fix this to 7.1 and skip 7.0.x The fix allows for splitting of the current 27 highlighting layers into two groups: 9 'bottom layers' and 18 'top layers'. Bottom layers are those that change metrics (font's name, style or size). Changes in these layers result in views rebuilding. Top layers (including e.g. caret row highlighting and text selection) do not change metrics and changes to them only result in repaints. Btw the two layer groups contents may be logged with -J-Dorg.netbeans.modules.editor.lib2.highlighting.HighlightingManager.level=FINER The fix should improve performance since view rebuilds are generally more expensive than just repaint notifications (and certain portions of the repaint e.g. for a large text selection may even not be visible and thus not physically repainted). Since this is a broad change there may be certain inefficiencies that I'll try to fix once I'll be sure that there are no functional regressions. I'd like to ask people on CC of this issue to test the change once it gets propagated into dev builds. Thanks. http://hg.netbeans.org/jet-main/rev/d4fa1c637d0a Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/d4fa1c637d0a User: Miloslav Metelka <mmetelka@netbeans.org> Log: #197534 - Improve efficiency of HighlightingManager together with View Hierarchy. *** Bug 190985 has been marked as a duplicate of this bug. *** *** Bug 198940 has been marked as a duplicate of this bug. *** *** Bug 199768 has been marked as a duplicate of this bug. *** *** Bug 200355 has been marked as a duplicate of this bug. *** *** Bug 201135 has been marked as a duplicate of this bug. *** *** Bug 201914 has been marked as a duplicate of this bug. *** *** Bug 192045 has been marked as a duplicate of this bug. *** *** Bug 192391 has been marked as a duplicate of this bug. *** *** Bug 192587 has been marked as a duplicate of this bug. *** *** Bug 194217 has been marked as a duplicate of this bug. *** *** Bug 194255 has been marked as a duplicate of this bug. *** *** Bug 194352 has been marked as a duplicate of this bug. *** *** Bug 194611 has been marked as a duplicate of this bug. *** *** Bug 194869 has been marked as a duplicate of this bug. *** *** Bug 200044 has been marked as a duplicate of this bug. *** *** Bug 199671 has been marked as a duplicate of this bug. *** *** Bug 199252 has been marked as a duplicate of this bug. *** *** Bug 198282 has been marked as a duplicate of this bug. *** *** Bug 198013 has been marked as a duplicate of this bug. *** *** Bug 197419 has been marked as a duplicate of this bug. *** *** Bug 197327 has been marked as a duplicate of this bug. *** *** Bug 196168 has been marked as a duplicate of this bug. *** *** Bug 196028 has been marked as a duplicate of this bug. *** *** Bug 196369 has been marked as a duplicate of this bug. *** *** Bug 195349 has been marked as a duplicate of this bug. *** *** Bug 193497 has been marked as a duplicate of this bug. *** |