This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Analytics UI doesn't display stacks in case there is '+' somewhere in file name | ||
---|---|---|---|
Product: | cnd | Reporter: | Maria Tishkova <mromashova> |
Component: | D-Light | Assignee: | Maria Tishkova <mromashova> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | akrasny, apepin, mmirilovic, vv159170 |
Priority: | P1 | ||
Version: | 7.0 | ||
Hardware: | Other | ||
OS: | Solaris | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | SQLSTackStorage.java : exception should not be thrown in constructor, FileNameUtils: be more accurate when parsing file names |
Description
Maria Tishkova
2011-04-01 20:59:27 UTC
Created attachment 107437 [details]
SQLSTackStorage.java : exception should not be thrown in constructor, FileNameUtils: be more accurate when parsing file names
fixed in cnd-main http://hg.netbeans.org/cnd-main/rev/8b9558d64fdb Add fix (print exception in system.err) http://hg.netbeans.org/cnd-main/rev/4118c5f0de7f This is a showstopper as Analytics doesn't work correctly The main problem was in an exception which was thrown in the constructor of the Object. It is catched now and if there will be some problems with functions info in the analytics it will be possible to resolve them in analytics code base. Vladimir, please review the fix ==Masha Andrew, I think it will be better and more correct if you will review the fix as you are dlight developer. Please review ==Masha Looks OK. But I would propose to remove lines 2.23 + String functionQualifiedName = getFunctionQName(functionSignature); 2.24 + int prev = indexOf; 2.25 + indexOf = functionSignature.indexOf(functionQualifiedName); 2.26 + if (indexOf >= 0 ){ 2.27 + indexOf = indexOf + functionQualifiedName.length(); 2.28 + } 2.29 + if (indexOf == 0){ 2.30 + indexOf = prev; 2.31 + } in FunctionNameUtils.java as (if!) their result is not used. The fix does not need verification. (In reply to comment #8) > The fix does not need verification. Ok, proceed with integration into release70 http://hg.netbeans.org/releases/rev/4251444646b5 http://hg.netbeans.org/releases/rev/b48d309ab29c http://hg.netbeans.org/releases/rev/af6f3b6a3d89 http://hg.netbeans.org/releases/rev/7be3614ffc5f Integrated into 'main-golden', will be available in build *201104050400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/08afa7b0d999 User: Maria Tishkova <mromashova@netbeans.org> Log: add fix to #197341, removed unused code. Use lastIndexOf("+Ox") instead of loop It does not need verification. |