This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | [70cat] org.openide.text.DataEditorSupport$1: The file cannot be safely opened with encoding UTF-8. Do you want to continue opening it? | ||
|---|---|---|---|
| Product: | platform | Reporter: | Vladimir Kvashin <vkvashin> |
| Component: | Data Systems | Assignee: | Vladimir Voskresensky <vv159170> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | amnesyac, anebuzelsky, azizur, bitray, cmygeHm, Ervis_Tusha, everflux, FabianBlechschmidt, gently, HTD, issues, javadimon, jtulach, kwasseem, malinens, masaki, mfukala, mmirilovic, musilt2, n0dwis, pekarna, pjiricka, rudyment, simpatico, St.Ev, Wierrat |
| Priority: | P1 | ||
| Version: | 7.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | 177783 |
| Attachments: |
stacktrace
One of projects, where sometimes the notice occures |
||
|
Description
Vladimir Kvashin
2011-03-22 08:27:42 UTC
Created attachment 107174 [details]
stacktrace
This bug already has 100 duplicates see http://statistics.netbeans.org/exceptions/detail.do?id=177783 This is last 'not yet evaluated' P1 in 7.0 . Could somebody do quick evaluation ? Thanks in advance. Related to the fix of issue 191323. David will have a look. Vladimir, this is coming from your patch ... can you please have a look? Thanks. can someone attach sample project to reproduce the issue? (In reply to comment #6) > can someone attach sample project to reproduce the issue? Sorry I don't have the project where it occured. I triggered the problem by not openening the file through the navigator or "open..." search box, but by clicking "hyperlink in code" (when holding the control key) I assume the hyperlink navigation triggeres a different code path. Created attachment 107312 [details]
One of projects, where sometimes the notice occures
Here is on of "problematic" projects. However the dialog notifying the seemingly problematic file appears only by first attemtp to open the file. After closing this file, the next oppening passes off sithout problems.
rudyment, thanks for the project. I was able to reproduce incorrect refjecting of true UTF-8 file. And I have a fix for that (which fixes issue #196707 as well) fixed. http://hg.netbeans.org/cnd-main/rev/1b8d3b85a037 Please, review and verify Integrated into 'main-golden', will be available in build *201103290400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/1b8d3b85a037 User: Vladimir Voskresensky <vv159170@netbeans.org> Log: fixed #196945 - [70cat] org.openide.text.DataEditorSupport$1: The file cannot be safely opened with encoding UTF-8. Do you want to continue opening it? -- check content of whole file, otherwise we incorrectly reject UTF-8 and also can corrupt user's file without notification (issue #196707 - Changes are made to unedited French characters while saving a file) Hi Vladimir, in the build where this fix appeared, one of the HTML encoding tests started failing: http://bertram.netbeans.org/hudson/job/javaee/2459/testReport/junit/org.netbeans.modules.html/EncodingTest/testLoadOfWrongEncoding/ Marek Fukala is the owner of this test, but he is on vacation until Wednesday. Could I please ask you to investigate whether the failure is related to your change, or whether it's unrelated? Thanks. Hi Petr,
this test was modified as part of issue
194634 - Failing tests on the javaee build job
But instead of commenting it out, it was reversed in logic.
I've checked in gedit and firefox and
"wrongencoding.html" is correct UTF-8 file...
I think test should be back outed to previous state:
public void testLoadOfWrongEncoding () throws Exception {
HtmlEditorSupport.showConfirmationDialog = false;
checkEncoding (null, "wrongencoding.html", false);
}
Peter, I've made it as http://hg.netbeans.org/cnd-main/rev/5fa8cc372598 Please, ask Marek to verify Vladimir, will you be able to integrate the fix of this bug today, so that it appears in today's nightly 7.0 build? I reviewed and have pushed Jan Lahoda's fix into trunk http://hg.netbeans.org/cnd-main/rev/b3fb8e05da46 Integrated into 'main-golden', will be available in build *201103310400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/b3fb8e05da46 User: Vladimir Voskresensky <vv159170@netbeans.org> Log: better fix (read once) for #196945 The file cannot be safely opened with encoding UTF-8 What is the status of this issue ? Looks like beside CND issues this one is the last not yet integrated into rlease70 branch. Please do it ASAP! Thanks. editor team, are you OK if I integrate it into release70? I this needs to be fixed in 7.0, I am OK with the last patch. integrated in 70: http://hg.netbeans.org/releases/rev/01978ab3ea68 http://hg.netbeans.org/releases/rev/606db3b6cb4b Integrated into 'main-golden', will be available in build *201104070400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/6c55c7e4ce5d User: Jan Lahoda <jlahoda@netbeans.org> Log: #196945: proper handling of UserQuestionException in CSL's UiUtils.doOpen. |