Bug 192625

The code completion slowness report
http://statistics.netbeans.org/exceptions/exception.do?id=445502
indicates that the code completion is blocked by an internet HTTP request initiated from
org.netbeans.modules.xml.text.completion.XMLCompletionProvider$Query.query()

At minimum the XML code completion needs to detect when it connects to network and notify user via:
http://bits.netbeans.org/dev/javadoc/org-netbeans-modules-editor-completion/org/netbeans/spi/editor/completion/CompletionResultSet.html#setWaitText(java.lang.String)

It sounds like this only affects the first-time usage when the schema is downloaded, and once it is downloaded, there is no slowdown. Requesting a waiver for NB 7.0.

The only necessary fix is to use setWaitText("Downloading DTD") by calling
http://bits.netbeans.org/dev/javadoc/org-netbeans-modules-editor-completion/org/netbeans/spi/editor/completion/CompletionResultSet.html#setWaitText(java.lang.String)
consider adding this one line change for 7.0.

Wait text change in web-main 6cca6ac3632e.

Passing to Petr to check or update waiver status and TM.

Thanks a lot - I am backing off the waiver request. Should be considered for 7.0, adding 70_HR_FIX_CANDIDATE keyword.

So can this be condered fixed (in trunk)?

(In reply to comment #5)
> So can this be condered fixed (in trunk)?

Go ahead.

Integrated into 'main-golden', will be available in build *201103160400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/6cca6ac3632e
User: phejl@netbeans.org
Log: #192625 Code Completion blocked by downloading DTDs

I consider it fixed.

Marian, please can you verify?

(In reply to comment #9)
> Marian, please can you verify?

I have no idea how to test it, but I approve your integration into release70

Transplanted into realease70 as 6ebef266b58f.

Note that the fix is wrong. It sets "Downloading DTD..." text to the completion popup regardless of what the CC query performers will do that what will take long.

See, e.g. issue 192628 which is about Maven CC perfomer which takes long while waiting for maven index. Unfortunatelly CC performers registered in XML cannot do anything with the setWaitText() method, they are only operating on xml's HintContext object, without the access to resultSet.setWaitText().

I suggest that this bug is fixed by changing "Downloading DTD..." to something more general like "Downloading...". It will also fix the issue 192628.

Integrated into 'main-golden', will be available in build *201103180400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/084de7752ae2
User: phejl@netbeans.org
Log: #192625 Code Completion blocked by downloading DTDs

Petr: could you please let me know once you fix bundle also in release70? I'll verify.

Transplanted as 919ba97c6722.

Guys, would be nice if you could watch HR process and reviewers list more carefully during the code freeze period to avoid reopening of HR_FIX bugs based on 3 months old P2 defect.

(In reply to comment #15)
> Guys, would be nice if you could watch HR process and reviewers list more
> carefully during the code freeze period to avoid reopening of HR_FIX bugs based
> on 3 months old P2 defect.

+1 !

verified.

Product Version: NetBeans IDE 7.0 RC1 (Build 201103210000)
Java: 1.6.0_24; Java HotSpot(TM) 64-Bit Server VM 19.1-b02-334
System: Mac OS X version 10.6.6 running on x86_64; MacRoman; en_US (nb)
Userdir: /Users/tomas/.netbeans/7.0rc1