This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 184229

Summary:	Deadlock from ToggleBookmarkAction
Product:	editor	Reporter:	Jaroslav Tulach <jtulach>
Component:	Actions/Menu/Toolbar	Assignee:	issues@editor <issues>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tboudreau
Priority:	P3	Keywords:	RANDOM, THREAD
Version:	6.x
Hardware:	Other
OS:	Linux
Issue Type:	DEFECT	Exception Reporter:

Description Jaroslav Tulach 2010-04-15 08:39:53 UTC

Tim's report #182960 shows a deadlock:
https://netbeans.org/bugzilla/attachment.cgi?id=96014

The AWT thread is blocked by EditorCookie.getOpenedPanes() called from 
at org.netbeans.lib.editor.bookmarks.actions.ToggleBookmarkAction.findComponent(ToggleBookmarkAction.java:147)

that call shall be replaced by new and non-blocking:
http://bits.netbeans.org/dev/javadoc/org-openide-text/org/openide/text/NbDocument.html#findRecentEditorPane(org.openide.cookies.EditorCookie)

Comment 1 Vitezslav Stejskal 2010-04-19 20:03:19 UTC

http://hg.netbeans.org/jet-main/rev/71cdbdf5186c

Comment 2 Quality Engineering 2010-04-21 04:38:19 UTC

Integrated into 'main-golden', will be available in build *201004210200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/71cdbdf5186c
User: Vita Stejskal <vstejskal@netbeans.org>
Log: #182249, #184229: using faster and non-blocking NbDocument.findRecentEditorPane rather than EditorCookie.getOpenedPanes