This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Do not load OptionalDeploymentManagerFactory when not really needed | ||
|---|---|---|---|
| Product: | serverplugins | Reporter: | Petr Hejl <phejl> |
| Component: | Infrastructure | Assignee: | Petr Hejl <phejl> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | apireviews, phejl, pjiricka |
| Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
| Version: | 6.x | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | 148177 | ||
| Bug Blocks: | |||
| Attachments: | the patch | ||
|
Description
Petr Hejl
2010-02-18 05:04:24 UTC
Please review the api change. The patch is supposed to be applied to sources with applied changes from #148177. Created attachment 94282 [details]
the patch
Are we doing this just to avoid loading 5 classes on startup, when at the same time we load 4 new classes? *.glassfish.* classes were missing in the whitelist. Actually not related to the change, sorry for the confusion. Correct "rate" is 5/1. Y01 A bit safer way to initialize in constructor is:
this.noInitializationFinish = Boolean.TRUE.equals(
attributes.get("noInitializationFinish")
);
Y02 I like the change. It is compatible, safe and improves scalability of the infrastructure. Together with the other changes we are on good track to eliminate loading in any code of non-installed server plugins completely.
Re Y01: Absolutely. I'll fix it before commit. I'll integrate the change tomorrow. Fixed in web-main 98591e9cd524. Integrated into 'main-golden', will be available in build *201002260200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/98591e9cd524 User: Petr Hejl <phejl@netbeans.org> Log: #180893: Do not load OptionalDeploymentManagerFactory when not really needed |