This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Attribute in the 'for' loop is not refactored | ||
---|---|---|---|
Product: | javafx | Reporter: | Alexandr Scherbatiy <sunflower> |
Component: | Unsupported | Assignee: | J Bachorik <yardus> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | sustaining |
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 173077 | ||
Attachments: |
screenshot of IDE after Refactoring > Rename on contacts in "list.contacts"
The result of rename refactoring on the provided source Refactoring result screenshot IDE log file with the exception stack trace |
Description
Alexandr Scherbatiy
2009-12-15 04:50:45 UTC
This is weird. It seems as if the IDE you are using is rather outdated. Please, make sure that the build contains changeset http://hg.netbeans.org/javafx/rev/b7a28b1cd91c When I try to reproduce the problem on the trunk build everything works as expected. Created attachment 92616 [details] screenshot of IDE after Refactoring > Rename on contacts in "list.contacts" I can reproduce it with Product Version: NetBeans IDE Dev (Build javafx-main-118-on-091215) from http://smetiste/builds/netbeans/6.8/fixes/2009-12-14_18-00-34/zip/ Obviously this is not fixed in the 6.8 branch. It is fixed in trunk by http://hg.netbeans.org/javafx/rev/b7a28b1cd91c I use the NetBeans-JavaFX-Soma Build #67 (Dec 16, 2009 12:00:35 AM) It uses JavaFX plugin sources from the trunk. The issue is reproduced on this build. I don't know what is going on with building the IDE with JavaFX plugin but if you use http://msice.czech.sun.com:8080/hudson/view/All/job/javafx-main/lastSuccessfulBuild/artifact/nbbuild/NetBeans-dev-javafx-main-120-on-091215-full.zip to verify this issue you will see that it is fixed. I hope somebody will point out a reference source for the trunk binaries - and it should be the one that builds reliably. This reopening and closing of the issue is just a waste of time for all involved parties :( Created attachment 92659 [details]
The result of rename refactoring on the provided source
Ok. The issue is reproduced in the NetBeans IDE Dev (Build javafx-main-120-on-091215) from: http://msice.czech.sun.com:8080/hudson/view/All/job/javafx-main/lastSuccessfulBuild/artifact/nbbuild/NetBeans-dev-javafx-main-120-on-091215-full.zip There is the exception in the IDE log file: WARNING [org.netbeans.api.javafx.source.JavaFXSource]: ParserManager.parse called in AWT event thread by: org.netbeans.modules.javafx.refactoring.impl.RefactoringActionsProvider$TextComponentTask.run(RefactoringActionsProvider.java:500) WARNING [org.netbeans.api.javafx.source.JavaFXSource]: - thread dump follows: WARNING [org.netbeans.modules.parsing.impl.TaskProcessor]: ParserManager.parse called in AWT event thread by: org.netbeans.api.javafx.source.JavaFXSource.runUserActionTask(JavaFXSource.java:250) java.lang.Exception: Stack trace at java.lang.Thread.dumpStack(Thread.java:1206) at org.netbeans.api.javafx.source.JavaFXSource.runUserActionTask(JavaFXSource.java:243) at org.netbeans.modules.javafx.refactoring.impl.RefactoringActionsProvider$TextComponentTask.run(RefactoringActionsProvider.java:500) at org.netbeans.modules.javafx.refactoring.impl.javafxc.SourceUtils.invokeAfterScanFinished(SourceUtils.java:631) at org.netbeans.modules.javafx.refactoring.impl.RefactoringActionsProvider.doRename(RefactoringActionsProvider.java:216) at org.netbeans.modules.refactoring.api.impl.ActionsImplementationFactory.doRename(ActionsImplementationFactory.java:83) at org.netbeans.modules.refactoring.spi.impl.RenameAction.performAction(RenameAction.java:62) at org.netbeans.modules.refactoring.spi.impl.RefactoringGlobalAction.performAction(RefactoringGlobalAction.java:132) at org.openide.util.actions.NodeAction.performAction(NodeAction.java:296) at org.openide.util.actions.CallableSystemAction$1.run(CallableSystemAction.java:127) at org.netbeans.modules.openide.util.ActionsBridge.implPerformAction(ActionsBridge.java:83) at org.netbeans.modules.openide.util.ActionsBridge.doPerformAction(ActionsBridge.java:64) at org.openide.util.actions.CallableSystemAction.actionPerformed(CallableSystemAction.java:123) at org.openide.util.actions.NodeAction.actionPerformed(NodeAction.java:284) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242) at javax.swing.AbstractButton.doClick(AbstractButton.java:357) at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1225) at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:1266) at java.awt.Component.processMouseEvent(Component.java:6263) at javax.swing.JComponent.processMouseEvent(JComponent.java:3267) at java.awt.Component.processEvent(Component.java:6028) at java.awt.Container.processEvent(Container.java:2041) at java.awt.Component.dispatchEventImpl(Component.java:4630) at java.awt.Container.dispatchEventImpl(Container.java:2099) at java.awt.Component.dispatchEvent(Component.java:4460) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168) at java.awt.Container.dispatchEventImpl(Container.java:2085) at java.awt.Window.dispatchEventImpl(Window.java:2475) at java.awt.Component.dispatchEvent(Component.java:4460) at java.awt.EventQueue.dispatchEvent(EventQueue.java:599) at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:125) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161) at java.awt.EventDispatchThread.run(EventDispatchThread.java:122) Created attachment 92663 [details]
Refactoring result screenshot
Created attachment 92664 [details]
IDE log file with the exception stack trace
I used the clean userdir. Ok. It seems that the trigger is selecting the whole token or putting the cursor after the last char of the token (like "for(contact in list.contacts|){"). If you place the cursor anywhere inside the token the refactoring works fine. Yes, I use mouse-double click to select the attribute. I tried to place a cursor inside the token and it works. verified in NetBeans-JavaFX-Soma: #93 The changeset has been ported into release68_fixes branch as http://hg.netbeans.org/javafx/rev/e026da9cc566 Please verify in next NB 6.8 fixes build Verified in NB 6.8 Patch1 2010-01-28_00-36-51 |