This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | [68cat] Wrong code genaration from interface | ||
|---|---|---|---|
| Product: | php | Reporter: | ingoreinhart <ingoreinhart> |
| Component: | Editor | Assignee: | rmatous <rmatous> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | pjiricka, sustaining |
| Priority: | P2 | ||
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
Hi, so if I understand this correctly, the workaround is to change the generated code by hand, right? Hi! Yes, and that 100 times a day. PHP is not typesave - so allmost string needs to be decleard in docblock. Ingo Unpleasant, on the other hand I think P2 is more appropriate here. Will be fixed ASAP Changing to P2 and marking as a patch candidate. Also, this piece of code is wrong and needs to be fixed:
interface PHPInterface {
/**
*
* @param PHPInterface $input
*/
public function myfunc($input);
}
class PHPClass implements PHPInterface {
public function myfunc(PHPInterface $input) {
;
}
}
Declaration in subclass needs to be compatible. Type taken from PhpDoc cannot be used for generating/overriding method in subclass.
Fixed in trunk: http://hg.netbeans.org/web-main/rev/b32cfc9eda87 Integrated into 'main-golden', will be available in build *200912051400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/b32cfc9eda87 User: Radek Matous <rmatous@netbeans.org> Log: #178103 - Wrong code genaration from interface Test with Build 200912060200 => all OK! Many thanks for the fast responce! reopening because we need to close this as verified to integrate to patch1 later. (and closed fixed doesn't give me chance go back to verified ;) ) closing as resolved fixed again Product Version: NetBeans IDE Dev (Build 091207-11903a3229df) Java: 1.5.0_17-ea; Java HotSpot(TM) 64-Bit Server VM 1.5.0_17-ea-b01 Reported by NetCAT 6.8 participant. The fix has been ported into the release68_fixes repository. http://hg.netbeans.org/release68_fixes/rev/7a9f64e095bd verified in Product Version: NetBeans IDE 6.8 (Build 201001261800) Java: 1.6.0_16; Java HotSpot(TM) 64-Bit Server VM 14.2-b01 |
Hello! I found lately one big error. Given this interface: interface PHPInterface { /** * * @param string $input */ public function myfunc($input); } Look at the @param line! If you now autogenerate a php function for myfunct the result looks like: class PHPClass implements PHPInterface { public function myfunc(string $input) { ; } } The result is a PHP parse error because string (in the method signature) is not allowed.