This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Can't switch off Memory checker | ||
---|---|---|---|
Product: | cnd | Reporter: | soldatov <soldatov> |
Component: | D-Light | Assignee: | Maria Tishkova <mromashova> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | akrasny, sustaining |
Priority: | P2 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
soldatov
2009-06-26 12:47:12 UTC
confirmed The problem is: 1. One instance of SunStudioDataCollector is used for all tools which use SunStudio 2. DataCollector and IndicatorDataProvider instances are created in the DLightTool constructor 3. Infrastructure reads XML files which contains all tools listed and create instances of all tools even if some of them are turned off The solution is: Created DataCollector and IndicatorDataProvider instances per request not in constructor of DLightTool fixed in cnd-mainhttp://hg.netbeans.org/cnd-main/rev/50bd94dabac7 Andrew, please review the fix and give your comments Valeriy, please check if the problem is fixed Verified in NetBeans with *.jar from developers. Problem is fixed. By default Freeway sample starts for 1 minute. If Memory and Thread indicators are switched off: less 1 second Integrated into 'main-golden', will be available in build *200906300200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/50bd94dabac7 User: Maria Tishkova <mromashova@netbeans.org> Log: fixed IZ#167696 Can't switch off Memory checker Maria, the fix looks ok. The only thing I would propose to change is one place with synchronization... bash-3.00$ hg diff dlight/src/org/netbeans/modules/dlight/api/tool/DLightTool.java diff -r 84b2352cae3a dlight/src/org/netbeans/modules/dlight/api/tool/DLightTool.java --- a/dlight/src/org/netbeans/modules/dlight/api/tool/DLightTool.java Mon Jun 29 22:55:43 2009 +0400 +++ b/dlight/src/org/netbeans/modules/dlight/api/tool/DLightTool.java Tue Jun 30 17:06:43 2009 +0400 @@ -80,7 +80,7 @@ private boolean collectorsTurnedOn = true; private final String iconPath; private final DLightToolConfiguration configuration; - private Boolean idpsInitialized = false; + private volatile Boolean idpsInitialized = false; //register accessor which will be used ne friend packages of API/SPI accessor packages //to get access to tool creation, etc. @@ -185,7 +185,7 @@ } private final void initIndicatorDataProviders() { - synchronized(idpsInitialized){ + synchronized(this){ if (idpsInitialized){ return; } Andrew, thanks for the comment! I have fixed the issue you mentioned: see rev http://hg.netbeans.org/cnd-main/rev/21672f550f51 fixed in cnd-main Integrated into 'main-golden', will be available in build *200907020200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/21672f550f51 User: Maria Tishkova <mromashova@netbeans.org> Log: add fix to IZ#167696 Can't switch off Memory checker according to comment of akrasny Verified in latest build from: http://bertram.netbeans.org/hudson/ and http://bits.netbeans.org/dev/nightly/ The fix has been ported into the release67_fixes repository. http://hg.netbeans.org/release67_fixes/rev/4cfedfc1b8c7 verified in nb6.7.1rc |