This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Failing tests | ||
---|---|---|---|
Product: | javaee | Reporter: | Petr Hejl <phejl> |
Component: | EAR | Assignee: | Jaroslav Tulach <jtulach> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | dkonecny, jglick, jjancura, pjiricka |
Priority: | P1 | Keywords: | TEST |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | j2ee.earproject tests seem to work fine now |
Description
Petr Hejl
2009-03-04 16:42:27 UTC
Are they? I just run web, ejb, and ear tests (on week or two old trunk sources) and most of them pass. Each module has about three failing tests but as far as I remember these were always failing. That's WORKSFORME. :-) After update to lastest sources I can reproduce the problem. Basically all project tests (web, j2se, ...) fail now because AntBasedProjectType cannot be found. I believe it is regression caused by issue 153655 by Jarda. I'm increasing to P1 priority because after couple of hours I could not resolve the problem and because it blocks integration of my M3 work. I could work around it by calling AntBasedProjectFactorySingleton.create() which could be acceptable solution inside project type tests but I do not want to copy and paste it to other project agnostic tests (eg. JSP editor tests which need Java classpath which in turn is provided by Web Project) Please list names of modules with broken tests. I am going to fix web.project, but tell me what all I shall fix. Thanks. Improved in http://hg.netbeans.org/ergonomics/rev/f4aeb4515e7e please get inspired or let me know what else shall I fix. Thanks I will have a look at the fix in a moment. The modules I know are failing are: web.project and java.j2seproject. This issue originally mentions that j2ee.ejbjarproject and j2ee.earproject are failing as well. Considering the type of your change - moving items from one lookup to the other - all project types which you've changed and which has some basic unit tests for project creation are broken. Integrated into 'main-golden', will be available in build *200903100201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/f4aeb4515e7e User: Jaroslav Tulach <jtulach@netbeans.org> Log: #159622: Fixing tests apperently failing due to use of @AntBaseProjectRegistration java.j2seproject tests improved in core-main#9d2fb1de3fb2 Btw. it might help in cases where tests don't mangle with lookup at all, if we change Lookup.getDefault() to include Lookups.forPath("Services") by default... Created attachment 77963 [details]
j2ee.earproject tests seem to work fine now
j2ee.ejbjarproject tests fixed in core-main#f656fb10a66f I guess as soon as the changes propagate, the known failures caused by @AntProjectBasedRegistration will be fixed. BTW if j2seproject owner(s) would fix their unit tests to all actually pass - last I checked there were open DEFECTs about tests known to fail - we would include this module in core-main's test suite, which would catch this kind of regression much earlier. Currently project.ant and similar infrastructure is tested, even ant.freeform & java.freeform, but not java.j2seproject pending a stable set of tests. I will look at our tests. Thanks. The more stable tests to run, the better. Btw. those tests are executed, just not part of commit validation: http://ruhudson4qe.russia/job/j2seproject/ I wasn't proposing inclusion of java.j2seproject tests in "commit validation" as such, just core-main's suite. It makes sense to run it there because changes to project.ant often affect tests in Ant-based project types (or even include patches to java.j2seproject), and in my experience a developer making such changes would usually want to check for regressions in j2seproject as a representative project type. Some of the tests are fairly slow, BuildImplTest in particular, but then again many platform test suites are slow. Integrated into 'main-golden', will be available in build *200903111543* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/9d2fb1de3fb2 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #159622: Fixing java.j2seproject tests by making sure that MockLookup includes also content of Lookups.forPath('Services'). Integrated into 'main-golden', will be available in build *200903251400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/78ae9b2b84ff User: Richard Michalsky <rmichalsky@netbeans.org> Log: #159622: fixing tests in o.n.m.apisupport.project.layers |