This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | no eclipse binding for in-place renaming refactor | ||
---|---|---|---|
Product: | editor | Reporter: | jonathanlocke <jonathanlocke> |
Component: | Key bindings | Assignee: | jonathanlocke <jonathanlocke> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | hmichel, jkovalsky, jonathanlocke, tboudreau, tusharvjoshi |
Priority: | P3 | Keywords: | NETFIX, SIMPLEFIX |
Version: | 6.x | ||
Hardware: | Macintosh | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | Patch for the required binding |
Description
jonathanlocke
2009-01-22 17:56:08 UTC
And what does command-option-r do? If anything? Thanks Vita Stejskal agreed that he would review and integrate a patch for this issue contributed by the NetFIX [1] team. [1] http://wiki.netbeans.org/NetFIX Currently NetBeans support Command+R for instant renaming if the Eclipse keybindings are selected. Eclipse has a shortcut Command+Option+R for instant renaming in Mac (checked with Eclipse Ganymede 3.4) I have managed changing this shortcut to the desired one and tested, and it works. The windows bindings for instant renaming are also Control+R Where as Eclipse has bindings SHIFT+ALT+R which can also be done. Is this understanding correct? If yes then I will attach the patch with this issue for review, according to the NetFIX process. with regards Tushar Joshi Created attachment 85840 [details]
Patch for the required binding
The patch attached has Windows and Mac bindings for Eclipse in-place rename shortcut as follows: Windows: SHIFT+ALT+R Mac: Command+Option+R To test this patch functionality 1. Activate Java SE plugin 2. Select Eclipse Key Bindings from Preferences dialog box 3. In any Java class file try to put cursor on a variable name identifier and press the shortcut key combination. 4. In place rename feature shall get activated Jonathan, can you please answer Tushar's questions in order to start review of the proposed patch? Thanks! dd9f35712718 - applied the patch and added 'Caret Color (Overwrite mode)' among Tools-Options -> Fonts & Colors -> Highlights. Thanks for the patch I'm sorry, please ignore my last message. It was supposed to end up in a different issue. Please review the patch attached and suggest any changes if needed with regards Tushar Joshi, Nagpur NetFIX local changeset: 2cd542ac6129 I had to tweak the patch a little bit. There are two rename actions in the IDE - in-place rename and full scale refactoring rename. The both ought to have the same shortcut. In Eclipse profile they both now have Alt-Shift-R on Windows and Command-Option-R on Mac. |