This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | SQL History: Dialog shouldn't be modal | ||
|---|---|---|---|
| Product: | db | Reporter: | Roman Mostyka <romanmostyka> |
| Component: | SQL Editor | Assignee: | John Baker <jbaker> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | CC: | sansan, sustaining |
| Priority: | P3 | ||
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | 152828, 153632 | ||
| Bug Blocks: | 152774 | ||
|
Description
Roman Mostyka
2008-11-13 16:09:45 UTC
This isn't defect, it's a modal dialog by design *** Issue 153222 has been marked as a duplicate of this issue. *** I think this is a feature not a defect or enhancement because this is a significant change and requires HIE input To improve the user experience it was much better if the SQL History window was not an modal dialog. For example: If this was an TopComponent i can place it everywhere i want. I am able to insert some statements in two or more SQL editor componentes without loosing my selection. to vote for this issue, click "Vote for this issue" +1, I agree with sansan, these are very good reasons for making it modal. Only being able to insert one at a time and having to close and re-open the window is a real pain. I'd like us to consider if we can do this in this release. I'll go ahead and add my vote :) Not to be considered as a task and may not get to for 7.0 unless there are more votes or priority is raised For now, I'll just make the dialog non-modal. I'd like to hear feedback, thanks 746af5efd11d If this is not what we want then please reopen It's a start, but I think what we really want is to make this a dockable window - I guess that's what "TopComponent" is. I suggest we discuss this at our next UI meeting with Mike. Verified. I filed an issue #153633 for the task to make "SQL History" dialog a dockable window. It can be closed after decision not to make this dialog a dockable window. Integrated into 'main-golden', will be available in build *200811220201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/746af5efd11d User: John Baker <jbaker@netbeans.org> Log: #153160 SQL History: Dialog shouldn't be modal Since this issue is P3 priority, in accord with rules "How to include issues into patch" (http://wiki.netbeans.org/NetBeansPatches) it must include an explanation as to why its backport is necessary and how safe it is. Could you please provide such explanation? Besides, this is an ENHANCEMENT maybe a FEATURE (based on JBaker's comment: "I think this is a feature not a defect or enhancement because this is a significant change and requires HIE input"). Neither enhancements nor features are intended to be in patches. Please, explain why this one should be included into the 65patch1 (or remove the status whiteboard). sansan, is it important to include this in the 6.5 patch or can the fix wait until 7.0 ? If this fix is included into the Patch 1, then fix for the issue #153632 also should be included. The fix for the issue #153632 is verified and both fixes should be in one patch. The required justification wasn't specified by 65patch1 code freeze. . The issue has been moved to 65patch2. The fix has been ported into the release65_fixes repository. http://hg.netbeans.org/release65_fixes/rev/642fb6222ad4 |