This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | [65cat] Can't save + can't discard overwrite -> DATALOSS | ||
|---|---|---|---|
| Product: | platform | Reporter: | ulfzibis <ulfzibis> |
| Component: | Text | Assignee: | mslama <mslama> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | CC: | jiriprox, jskrivanek, jtulach, lhasik, mslama, musilt2, ppis, sustaining |
| Priority: | P2 | ||
| Version: | 6.x | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | 150818 | ||
| Bug Blocks: | |||
| Attachments: |
Can't save
Can't discard log log1 log2 No Discard on "Overwrite externally modified file?" Refactor->Rename caused undiscardable "Warning" Cannot "Save All" after refactoring log file |
||
|
Description
ulfzibis
2008-10-29 22:15:59 UTC
Created attachment 72854 [details]
Can't save
Created attachment 72855 [details]
Can't discard
Sorry, I mixed the order of the attached screenshots. First was: *_2.jpg = "Can't save" Second was: *_1.jpg = "Can't discard" It looks as issue 149330 however it is different way how to get it. The only OK button is described in issue 150818. I'm not able to reproduce it however it may be caused by the fact that my sources are not versioned (VCS). What VCS do you use? Could you try to reproduce with -J-Dorg.openide.text.level=100 and attach the log here -> INCOMPLETE for now thank you VCS = subversion 1.5.4 Created attachment 72921 [details]
log
Created attachment 72922 [details]
log1
Created attachment 72923 [details]
log2
Are you able to reproduce with non versioned files? Are you able to reproduce this with latest trunk build? I assume you have files you refactor opened in editor. Issue 150818 is about Bundle file ie. properties file. It is handled by different code not by CES/DES in openide.loaders/openide.editor. > Are you able to reproduce with non versioned files? Are you able to reproduce this with latest trunk build? Maybe next days :-( You are right, some, probably all, of the renamed classes had been open in editor at that time. BTW: You can checkout the project here: https://java-nio-charset-enhanced.dev.java.net/source/browse/java-nio-charset-enhanced/?rev=470 - I had renamed all *Indexed* to *Paged* - In case of sun.nio.cs.US_ASCIIOffsetIndexedMapEncoder, I first erroneously renamed to US_ASCIIPagedIndexedMapEncoder, and later to US_ASCIIOffsetPagedMapEncoder, which caused the issue. - final result (after external repair): rev=471 It looks like duplicate of #149330. Please test with NB 6.5 FCS or latest trunk dev build. There should be no * after refactoring. I was able to reproduce with your project. The bug appears whenever you rename a class opened in editor two times subsequently. However it seems that it is reproducible only on windows. I can reproduce it with NB65 and trunk (200811251401) subversion client on Windows is externally modifying java file after file is saved from editor. It is easy to reproduce on Win XP. 1.Create local svn repo. 2.Create simple Java SE project with Main.java. 3.Import this project into svn repo. 4.Open Main.java in editor 5.Refactor->Rename Main.java (keep in the same package) eg. to a.java 6.Modify a.java in editor. 7.Save it. Dialog that file was modified externally appears. It does not happen when file/project is not in svn repo. There was also bug in DataEditorSupport which caused incorrect (original) file name was displayed in this dialog. I already fixed this as issue #154095 and changeset #d7a3a55ba8db. Note: When I imported project to svn I selected default bundled svn client in IDE. Note: You can repeat this as necessary. Just revert svn changes. Close new file in editor with Discard changes. Delete new file created by rename. Open original file in editor, restart IDE and you can repeat with step 4. We debugged with Jarda and there is no setLastSaveTime in code. Now CES/DES uses strictly file time stamp. You can use FileMon to find out who touches file in question. Good catch! So bug is in Subversion client ? the svn move command is changing a files timestamp. Unfortunately, the svn module has no control over it. Is there any chance to refresh the timestamp value not only after a file change, but also after a rename? please evaluate Moving a file in Windows normally does not touch it's timestamp, also renaming. So IMHO consider of a bug in SVN. core-main #54a007e7f51c "expectedTime" event is used to update lastSaveTime in CES when fileRename event comes from file to DES. It handles case when svn client externally changes file timestamp during rename (Refactor->Rename on file under svn). it needs to be verified properly on different setups and different VCS. I'm marking as candidate for patch 2 of NB65 Integrated into 'main-golden', will be available in build *200812030201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/54a007e7f51c User: Marek Slama <mslama@netbeans.org> Log: #151787: Sync timestamp when svn client changes timestamp externally during rename. *** Issue 153175 has been marked as a duplicate of this issue. *** *** Issue 154402 has been marked as a duplicate of this issue. *** *** Issue 155624 has been marked as a duplicate of this issue. *** No Discard on "Overwrite externally modified file?" After Refactor->Rename of a class, it did some editing on it. Then I did "Save All" or "Run single Test" (Sorry, I don't remember), and got Warning instead of Error. See Attachment ... Created attachment 75347 [details]
No Discard on "Overwrite externally modified file?"
Sorry for error: After OK, now I can see that I did Refactor->Rename of a variable, before I got the "Warning". See next Attachment ... Created attachment 75348 [details]
Refactor->Rename caused undiscardable "Warning"
Created attachment 75349 [details]
Cannot "Save All" after refactoring
I got rid of those messages by workaround: File->Save As "MyClass.java.bak" :-) The issue hasn't passed the nomination process for 65patch2 by cut-off date. It has been moved to 65patch3. Please could you sum current status? Steps to reproduce? Again I assume you are on Win XP and your files are in svn repo. Also part of IDE log with this exception would help. Yes, I am on Win XP and my files are in svn repo: https://java-nio-charset-enhanced.dev.java.net/source/browse/java-nio-charset-enhanced/ Steps to reproduce? It's too long time ago. I can't say more, than I had written. The oldest log, I have, is from 6. Jan. Created attachment 75827 [details]
log file
I will try to play with renaming. Closing. If anything like this happens again with latest dev build please file new issue and I will try to evaluate soon. marking verified release65_fixes #ef0f2b16f3fa *** Issue 160029 has been marked as a duplicate of this issue. *** *** Issue 151501 has been marked as a duplicate of this issue. *** |