This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | DiffFileEncodingQueryImpl class is loaded twice during NetBeans startup with LimeWire project | ||
|---|---|---|---|
| Product: | versioncontrol | Reporter: | Alexander Kouznetsov <mrkam> |
| Component: | Code | Assignee: | Ondrej Vrabec <ovrabec> |
| Status: | REOPENED --- | ||
| Severity: | blocker | CC: | issues, jtulach |
| Priority: | P4 | Keywords: | PERFORMANCE, TEST |
| Version: | 6.x | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| URL: | http://wiki.netbeans.org/FitnessViaWhiteAndBlackList | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: |
Stacktraces
Stacktrace |
||
|
Description
Alexander Kouznetsov
2008-10-08 20:25:30 UTC
Created attachment 71409 [details]
Stacktraces
> Please don't load these classes unless they are really necessary versionig utilities exprts FileEncodingQueryImplementation. That's what DiffFileEncodingQueryImpl is for. if DiffFileEncodingQueryImpl gets loaded it's not a cause or fault of vcs > Why is there similar class twice? diff can't use the encoding query facility provided by vcs utilities as it is vcs utilitities which depends on diff ... It is not Alexander's nor performance team primary responsibility to identify whether vcs is responsible or not. We
just identified that a class is loaded uselessly and reported bug to fix that.
Looking at the DiffFileEncodingQueryImpl, I can see that it returns null for every file having other mimetype than
text/x-diff. This seems to me that you need to change the registration of the DiffFileEncodingQueryImpl to make the
class activated only when encoding of such file is in question. Currently I know only about one way to achieve that:
you can put the query into proper DataObject's getLookup.
> diff can't use the encoding query facility provided by vcs utilities as it is vcs utilitities which depends on diff
It does not sound like real argument to me. Cann't you let vcs use the diff functionality?
Another similar class in the list of loaded classes during startup with LimeWire project: org.netbeans.modules.diff.DiffFileEncodingQueryImplementation Please don't load this class unless it is really necessary. Created attachment 71768 [details]
Stacktrace
|