This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Need to add newly created module org.netbeans.modules.xml.wsdlui.api as friend of xml.xam, xml.xam.ui and catalogsupport | ||
---|---|---|---|
Product: | xml | Reporter: | malkit <malkit> |
Component: | XAM | Assignee: | Samaresh Panda <samaresh> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | sustaining |
Priority: | P3 | ||
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: |
Description
malkit
2008-09-26 21:35:06 UTC
adding 61fixes4-candidate to status. How can I explain, enhancements are enhancements. They are normally developed/fixed in new releases and not in patches. Secondly, why would you need to create a new module for a patch? Seems like a whole new set of functionality are being added as a patch. malkit, are you trying to expose some of these internal APIs through your module? If so, let me add a word of caution that friends are friends. There is no formal contract between them and the APIs can change anytime. Please read this: http://openide.netbeans.org/tutorial/api-design.html#life and read the friend relationship. As regards to my talk with Samaresh just now, here is the complete list of modules that I would need to be added as friend to this new module. xml.xam.ui xml.validation xml.refactoring xml.catalogsupport xml.axi xml.wsdl.refactoring Could QE verified the issue in the trunk ASAP? Sustaining needs to port the changeset into the release61_fixes by Friday 03-Oct-08 and the issue have to be verified in trunk before the port. Thanks!! While we are waiting for QE to verify this, if my verification helps, I can verify (looking at the changeset) that for 6.5 all the requested modules have allowed friend access to this module. Verified on Windows Vista with Netbeans 6.5 trunk hudson continuous build #3954 from http://deadlock.netbeans.org/hudson/job/trunk/. (As of 10:13 pm Central US time, the nightly builds at http://bits.netbeans.org/dev/nightly/ hadn't appeared.) The following modules now include org.netbeans.modules.xml.wsdlui.api in the OpenIDE-Module-Friends in their META-INFO/MANIFEST.MF files (all directories relative to <netbeans_main>: xml.xam.ui (xml2/modules/org-netbeans-modules-xml-xam-ui.jar) xml.validation (xml2/modules/org-netbeans-modules-xml-validation.jar) xml.refactoring (xml2/modules/org-netbeans-modules-xml-refactoring.jar) xml.catalogsupport (xml2/modules/org-netbeans-modules-xml-catalogsupport.jar) xml.axi (ide10/modules/org-netbeans-modules-xml-axi.jar) xml.wsdl.refactoring (xml2/modules/org-netbeans-modules-xml-wsdl-refactoring.jar) I will proceed with porting to release61_fixes branch based on the above comment. Once the issue is verified in a nightly build at bits.netbeans.org change, please the issue status to verified. The fix has been ported into the release61_fixes branch: http://hg.netbeans.org/release61_fixes/rev/457a7e3b3b42 Integrated into 'main-golden', will be available in build *200810031107* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/864c2e0a27b2 User: samaresh@netbeans.org Log: #148522 Added org.netbeans.modules.xml.wsdlui.api as friend to 6 xml modules. Verified on NB 6.1 with patch 4 installed: The following modules now include org.netbeans.modules.xml.wsdlui.api in the OpenIDE-Module-Friends in their META-INFO/MANIFEST.MF files (all directories relative to <netbeans_main>: xml.xam.ui (xml2/modules/org-netbeans-modules-xml-xam-ui.jar) xml.validation (xml2/modules/org-netbeans-modules-xml-validation.jar) xml.refactoring (xml2/modules/org-netbeans-modules-xml-refactoring.jar) xml.catalogsupport (xml2/modules/org-netbeans-modules-xml-catalogsupport.jar) xml.axi (ide9/modules/org-netbeans-modules-xml-axi.jar) <== NOTE Different ide # than for NB 6.5. xml.wsdl.refactoring (xml2/modules/org-netbeans-modules-xml-wsdl-refactoring.jar) Verified with NB 6.5 netbeans-trunk-nightly-200810031107-windows.exe as described in earlier comments for NB 6.5 builds. |