This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | I18N - local variables don't show ok if multibyte characters used as values | ||
|---|---|---|---|
| Product: | php | Reporter: | luwei <luwei> |
| Component: | Debugger | Assignee: | Ondrej Brejla <obrejla> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | jf4jbug, kfrank, mmirilovic, nexxer, OndrejBrejla, pjiricka, webfox |
| Priority: | P2 | Keywords: | I18N |
| Version: | 6.x | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Issue Type: | DEFECT | Exception Reporter: | |
|
Description
luwei
2008-08-20 10:12:15 UTC
could you attach a gif of the editor showing incorrect display of the values and also php file with the kind of code you are using ? also, where does the variables value not display ok - is it in the debugger window ? finally what platform are you on and what is the locale or regional settings you are using ? ken.frank@sun.com confirming this is seen on windows. this is not about name of the variable or other programattic/lanaguage types being in multibyte - this is just about the values, and that seems to be allowed (we've already discussed in other issues that for php use of non ascii not supported in names of variables, or project names,paths. the value does show ok in editor and in browser when php is run. and when project encoding property is the default encoding of the locale, in my case win31j, the variable values show ok in local vars window (issue filer sees it using default utf-8 project encoding) thus its probably related to encoding assumptions being used. this probably should be p2 since it is about actual data. ken.frank@sun.com Integrated into 'main-golden', will be available in build *200904150201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/494788efc282 User: Radek Matous <rmatous@netbeans.org> Log: #144548 I18N - local variables don't show ok if multibyte characters used as values Still reproducible on 6.7 beta and latest dev build. Set source encoding to UTF-8 and run on Windows (SJIS). Screenshot: http://ja.netbeans.org/servlets/GetAttachment?list=netcat67&msgId=2038060&attachId=1 NetBeans IDE 6.7 Beta (Build 200904242137) Java: 1.6.0_13; Java HotSpot(TM) Client VM 11.3-b02 Windows XP 5.1; MS932; ja_JP (nb) NetBeans IDE Dev (Build 200905291401) Java: 1.6.0_13; Java HotSpot(TM) Client VM 11.3-b02 Windows XP 5.1; MS932; ja_JP (nb) I have a question: in the fix http://hg.netbeans.org/web-main/rev/494788efc282 It seems that just using "UTF-8". + is.setEncoding("UTF-8"); Shouldn't we consider source encoding of project here? Users would be able to set any encoding other than UTF-8. batch reassigning Fixed in web-main: http://hg.netbeans.org/web-main/rev/e5416424aa33 Integrated into 'main-golden', will be available in build *201103300400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/e5416424aa33 User: Ondrej Brejla <OndrejBrejla@netbeans.org> Log: #144548 - I18N - local variables don't show ok if multibyte characters used as values *** Bug 197351 has been marked as a duplicate of this bug. *** Ondro, do you think that the fix is safe to transplant into NB 7.0? I think that it's safe and that there are no threats. If a problem occurs during fetching the debug session for runtime options (with a project encoding), there is a fallback to the same behaviour which worked before the fixation. I would like to transplat the fix into 7.0. Could I ask QE for testing? Thanks. (In reply to comment #12) > I would like to transplat the fix into 7.0. Could I ask QE for testing? Thanks. Hmm, was a P3 for long time, without any escalation. I think we can release 70 without this fix and let it integrated into 7.0.1. The bug has 3 votes and at least one duplicate. If it will not be a pat of NB 7.0 it will be part of the next release. This an email that I have received a while ago from Petr Ungern: -------------------------------------------------------------- Sorry that I comment on this bug. Its real not convenient if debug values are not readable, and as it is fixed in this present development version, it would be real good to have it in 7.0, and not in any later coming version. NB is not only used by plain English users... -------------------------------------------------------------- Personally I think that the fix should go to the NB 7.0, if the fix is save. There are many people who use the PHP with different encoding. I love NB, and if multibyte characters are unreadable displayed in debugging then its real not very helpful. I tested this latest development version (Ondrej recommended me to test it) extensive, and it works extremely fine. Would real appreciate if this fixed bug would be in NB 7.0, as otherwise I would have to stick to this development version, instate to use 7.0 containing still this bug, and to wait for an NB version that fix it. Debugging in different UTF encodings is important for me and I guess a lot other users. Hope that NB 7.0 will contain this fix. Thanks for your attention. As I remember correctly, I got at least 4 questions about this issue on the local mailing list in Japan since NetBeans began to support PHP. Windows is one of the major development platforms so most PHP developers using NetBeans meet this issue. Ok, I see your arguments, just do not understand why this issue got fixed so late in release cycle ? Anyway, I agree with integration into release70 TODAY, BUT I would like to ask all participants to test the bits for potential regressions once RC2 build is out. Thanks in advance. I have just transplanted Ondra's fix into release70. The answer for question, why it's fixed so late, it easy. Resources. It was P3 and I don't have time even evaluate the P3 bugs. I'm still solving P1 and P2. Thanks Ondra to helping with issues. |