This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Tree Tagging support for Java Source | ||
|---|---|---|---|
| Product: | java | Reporter: | Max Sauer <msauer> |
| Component: | Source | Assignee: | apireviews <apireviews> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | jlahoda |
| Priority: | P2 | Keywords: | API_REVIEW_FAST |
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Attachments: |
added methods, sample implementation for CreateMethodFix
tagging test |
||
I propose to add two above mentioned methods. Created attachment 63426 [details]
added methods, sample implementation for CreateMethodFix
Could you describe use cases? Yes, sure. - Using hint to create method leads to a new method created, with default method body (ie. 'throw new UOE'). Presumably, user would like to change it to something more reasonable. Currently, the method body (the throw statement) is not selected inside editor and the caret position is two lines below the created method. This would enable selection of generated method body automatically right after method creation. - Initialize variable hint -- selection of newly created default value (not yet implemented) - Possibly some other hints also Y01 little bit of tests would be nice Y02 why is the setter synchronized and getter not synchronized? re Y01: ok. re Y02: its not exactly getter and setter. The 'tag' method is inside WorkingCopy class and will be typically called from modifactiontask's run. The so-called getter, on the other hand, is a method of ModificationResult class and will be called after the modification task is finished (no need to be synchronised imho). Created attachment 63607 [details]
tagging test
|
An API change is required to be able to select trees inside java editor, which is useful for java hints. /** * Provides span of tree tagged with {@code tag} * @param tag * @return borders in target document * @since 0.37 */ public int[] getSpan(Object tag) ... /** * Tags a tree. Used in {@code ModificationResult} to determine position of tree inside document. * @param t the tree to be tagged * @param tag an {@code Object} used as tag * @since 0.37 */ public synchronized void tag(Tree t, Object tag) Proposed change is compatible. I'll attach a diff.