This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Should be able to edit multiple fields in ShowData by tabbing | ||
---|---|---|---|
Product: | db | Reporter: | David Vancouvering <davidvc> |
Component: | Show Data | Assignee: | Libor Fischmeistr <lfischmeistr> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | mastero23, paolosca, romanmostyka |
Priority: | P2 | Keywords: | PATCH_AVAILABLE |
Version: | 6.x | ||
Hardware: | Macintosh | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 152820 | ||
Attachments: |
Proposed patch
Proposed patch v2 Fix insert record dialog |
Description
David Vancouvering
2008-06-11 01:17:55 UTC
Lets do this in the end if we get some time. FYI, the way you do this is by setting the target milestone to "future" rather than closing the bug. I did not find any easy way to do this. I have also not seen this feature other SQL editors, downgrading. This is mostly fixed in new Insert Dialog Reassigned to new owner. Created attachment 148982 [details]
Proposed patch
This patch allows continuous editing of multiple cells if you use TAB or SHIFT-TAB to navigate.
This looks very good! I tested on linux with the LAFs: Metal, Nimbus, CDE, Gtk. They all work. Please have a look at InsertRecordDialog.java, there InsertRecordTableUI is subclassed and changeSelection is overriden to implement the behaviour you archived here (your version looks much saner). I commented out the inline override (lines 123-146, Version from main-golden) and the behavior you implemented works correctly also in the input dialog. Created attachment 149029 [details]
Proposed patch v2
Created attachment 149030 [details]
Fix insert record dialog
I've attached a new patch that removes the lines 129-144 from InsertRecordDialog.java. I didn't remove the complete changeSelection function, because it enables the 'Remove' button. This patch also fixes #206101. There's a new version of the original patch. In v1 there was no cursor when StringTableCellEditor got the focus. I gave it another spin and this looks good - the unittest still work, the behaviour is the desired one. I think this is good to be committed. @Libor - could you please give it another look and commit it (both patches are needed)? *** Bug 155986 has been marked as a duplicate of this bug. *** *** Bug 206101 has been marked as a duplicate of this bug. *** Reviewed on Windows. Looks good to me. Patch and fix applied in changeset http://hg.netbeans.org/core-main/rev/789a98ecc677 Thanks to Markus for the patch and Matthias for the review. Integrated into 'main-silver', will be available in build *201412090001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/789a98ecc677 User: Libor Fischmeistr <lfischmeistr@netbeans.org> Log: #136967: Should be able to edit multiple fields in ShowData by tabbing |