Bug 133517

Created attachment 60510 [details]
element with ja chars in name

if this is side effect from fix of 132362 then it probably

should be fixed for the patch1 also.

Andrey, provide details about this here.

ken.frank@sun.com

I believe I checked it before.
Probably it is a side effect of the recent changes. Also I noticed the following behavior:

1. Create XML schema
2. DnD an element
3. Dnd Choice below it

It appears on the diagram with prefix and suffix. They are looking ok in Japanese.

4. Select the Choice at the Diagram

It appears in bold font and its prefix and suffix are now substituted by square boxes.

Created attachment 60608 [details]
image

Erno and Sam,

since I think the fix for these kind of situations is known and not a lot of
code, could the fix for this and others situations
in these modules that Erno had seen be fixed also
for the first patch (like 132362 was), since it means in these
cases either translated messages/labels
or users own use of multibyte would show as boxes,
and user would not know what is there ?

I can file separate issues if needed if can tell me based on code search what other ui items
have this boxes problem.

ken.frank@sun.com

ken.frank@sun.com

Sorry, I can't reproduce this. I'm following Ken's instructions on setting up a pseudo localization. When I drag-drop an
element, "newElement" name appears. See attachment.

Created attachment 60627 [details]
design view

Sam, please refer to original attachement; I think what is being said
is that if the element name is changed to have multibyte characaters,
that thats the time those chars are seen as square boxes.

in gif you attached the name for the element is "newElement"
or "newComplexType" but in original gif that name was changed
to have multibyte, in other words the name Andrey used is 2 multibyte
characters, thus 2 square boxes.

the multibyte in the other parts of your gif are correct.

Can you try again on windoes using ja characters as the element name ?

ken.frank@sun.com

I'm sorry, how can I have Ja characters for element or complex type again? I found another issue: If you drag an element
and hover over an existing element, you get a bulb-info that says "drop here to add...." and I do see square boxes
around it. I'll fix that. For the first one, I need more info.

Fix integrated: http://hg.netbeans.org/main/rev/ad809b34cc71.
Note: DV code is complex and hence do not be surprised if you uncover few more.

Andrey, please verify now so we can get it in first patch. thanks.

I don't see why this fix couldn't be included in patch1 as well, though it is really up to the xml team and sustaining. 
BTW, the fix changes the font style from bold to plain in some places, not sure whether that is intentional or not. 
Also, the change below looks a bit suspicious, why do you need to create the new font using getFontName here?:

--- a/xml.schema.abe/src/org/netbeans/modules/xml/schema/abe/InplaceEditableLabel.java	Wed Apr 23 14:30:01 2008 -0500
+++ b/xml.schema.abe/src/org/netbeans/modules/xml/schema/abe/InplaceEditableLabel.java	Wed Apr 23 19:28:52 2008 -0500
@@ -165,7 +165,9 @@ public class InplaceEditableLabel extend
         if(mouseOverMe && altKeyPressed && (ctrlClickHandler != null) ){
             //draw diff color and underline
             Color origC = getForeground();
-            Font origF = getFont();
+            //Font font = getFont();
+            //Font font = origF.deriveFont((origF.getStyle() | java.awt.Font.PLAIN), origF.getSize()+2);
+            Font font = new Font(getFont().getFontName(), Font.BOLD, getFont().getSize() + 2);

The patch nomination process states that the issue must be fixed/verified in the trunk before the nomination. If you
want to get this issue into the patch1, please verify it.

Product Version: NetBeans IDE Dev (Build 200804210001)
Java: 1.6.0_05; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP version 5.1 running on x86; MS932; ja_JP (nb)
utf-8 and win-31j project encodings

to kaa,

how can this be verfied in 200804210001 dev build
when that is the build in which the problem was seen
and fix happened after that date (final fix happened on today 4/24)

am reopening until this can be clarified.


Erno, should another issue for now or future be filed for additional
comments about another part to be fixed ?

ken.frank@sun.com

I copy then paste wrong build version.
I used for verification the following build

Product Version: NetBeans IDE Dev (Build 20080424124045)
Java: 1.6.0_05; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP version 5.1 running on x86; MS932; ja_JP (nb)

please switch bach to verified.
I'll recheck all other issues for this

The issue hasn't be fixed till 61patch1 nomination cut-off date.
Marked as release61_fixes_candidate2.

Ken: Not sure, the usage of getFontName that I mentioned might cause problems, but maybe there was a reason for doing 
it like that. The font style change, if it wasn't intentional, might be an issue depending on the UI guidelines for the 
UI in question here (I'm not familiar with it).

for some reason, andrey did not reverify this as part of the last
comments that it was verified, and since sustaining needs to know
it was verified so can be in patch 1, will resolve and then verify it.

ken.frank@sun.com

verified.

I've transplanted the changeset http://hg.netbeans.org/main/rev/ad809b34cc71 into release61_fixes repository as
http://hg.netbeans.org/main/rev/bddccd4c0702

changeset:   77485:bddccd4c0702
tag:         tip
user:        samaresh@netbeans.org
date:        Wed Apr 23 19:28:52 2008 -0500
summary:     Issue 133517: i18n square boxes in DV.

Oops, the correct URL to backported changeset is http://hg.netbeans.org/release61_fixes/rev/bddccd4c0702

rechecked with fcs build and patch1.
The fix looks ok.

used both default and 16 font size