This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | I18N - XML Schema Design View has square boxes instead of Japanese characters | ||
---|---|---|---|
Product: | xml | Reporter: | kaa <kaa> |
Component: | Schema | Assignee: | Samaresh Panda <samaresh> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | emononen, jf4jbug, kfrank, mkleint, sustaining |
Priority: | P2 | Keywords: | I18N |
Version: | 6.x | ||
Hardware: | All | ||
OS: | Windows XP | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
image
Design view new fix image |
Description
kaa
2008-04-08 19:55:47 UTC
Created attachment 59861 [details]
image
It looks the similar with 131833. Reproducible on WinXP in ja_JP locale. Project encodings UTF-8 and Win-31j. Was it ever tested with Ja locale or you're testing this very first time? are you using the trunk build that has final fix to 131833. if not this might be an not valid issue. and I'm not aware of providing pseudo localization for a build that has the fix so not sure how this might be valid issue at this point since build you are using still has the 131833. see that issue for what build to use and find out which jar files need to be pseudo localized to show just this problem. also this issue does not tell if ide run with --fontsize option or not and behavior in each case. I am marking as incomplete, remove keyword when provided information is obtained and update issue or close if fixed as part of other issue fix. ken.frank@sun.com I think this module does not use xml/multiview, so the fix for issue 131833 did not fix this. The problem is caused by using a particular font face when creating fonts, e.g. : new Font(font.getFontName() .. ) Replacing those usages in the code should fix this, similarly as in issue 131833. I didn't use trunk build. I used netbeans-6.1rc1-200804060802 with pseudo bundle 0406. Checked in trunk build 0408 with and without font size option: The fix for 131833 exists there but the problem with xsd file is also present. This issue looks close to the 131833 but I couldn't assume that they have the same fixes. At the begging of the description I mentioned that font size was 16. The issue is also reproducible without this option using default value. This is not a P1 and arrived after the cut-off for P2s. Does it have to be fixed for 6.1? I think it should since 131833 with similar problems was but only if the fix is very low impact and won't have possibility of effecting anything else, especially about other font situations as to them not displaying ok. the reason is that, to user using translated nb, assumption is that they dont know english, and if they see the square boxes, they won't know what it says. ken.frank@sun.com I'm afraid there is nothing for me to fix. We have three MV descriptions Source, Schema and Design (that implements MultiViewDescription) and they return "Source", "Schema" and "Design" as their display names. These are set in org.netbeans.core.multiview.TabsComponent.java, line 212-213. Mnemonics.setLocalizedText(button, description.getDisplayName()); button.setModel(new TabsButtonModel(description)); I think it needs to be fixed there. CC'ing Milos for his take. But I have to ask again, why was this not an issue before and surfaced just yesterday. This part of the code was not touched for years. Schema/Design view used to exist in 6.0 as well. Was 6.0 not tested with Ja locale? Sorry ignore my last comment, I looked at the wrong code. Created attachment 59940 [details]
Design view
Ken, please try the new jar and let me know if the fix helps. I mean copy the jar to <NB>/xml2/modules. can I use previous pseudo localized jars for this test - that is, fix is just to code, not to messages ? ken.frank@sun.com I used a trunk build of 0406 and replaced the attached jar, but it did not help. I ran using --fontsize option and not --fontsize option is it needed to use a more recent trunk or 6.1 build to do this ? ken.frank@sun.com Let me look into this... can this be fixed in trunk soon so it can go into first 6.1 patch ? that seems to be requirement that it be fixed in trunk first. I added the status whiteboard word here also. ken.frank@sun.com Created attachment 60231 [details]
new fix
Ken, please try the new jar before you have a build for this fix. I'll commit this in the mean while. Fix integrated: http://hg.netbeans.org/main/rev/9786773b4f26. looks ok using attached jar using recent 0406 6.1 started ide with --fontsize option and not with it question - might this fix have any impact on any other ui parts of xml or other areas ? that is, what other ui objects/labels/etc are affected by this - we want to make sure they look ok too finally, we will verify it in trunk soon as well and mark verified there. ken.frank@sun.com It'll only affect design view. checked in trunk build: Product Version: NetBeans IDE Dev (Build 200804210001) Java: 1.6.0_05; Java HotSpot(TM) Client VM 10.0-b19 System: Windows XP version 5.1 running on x86; MS932; ja_JP (nb) Created attachment 60513 [details]
image
The fix needs to be in release61 branch to be able to be in patch. Please put it there after final 6.1 fcs. Andrey, put info here about newly found 133517 since it seems this has appeared only since fix for this issue ? ken.frank@sun.com Probably, the fix has side effect: Multibyte chars in names of the Palette elements are shown with square boxes. See issue 133517. Not necessarily a side effect, there still seem to be a few places in the xml/schema/abe module where a font is created using a particular font face. I did not look at those usages in detail though, just did a quick grep search in the module. Erno, since I think the fix for these kind of situations is known and not a lot of code, could the fix for 133517 and others situations in these modules that you found be fixed for the first patch, since it means in these cases either translated messages/labels or users own use of multibyte would show as boxes, and user would not know what is there ? I'll add this info to the other issue. ken.frank@sun.com I've transplanted the changeset http://hg.netbeans.org/main/rev/9786773b4f26 into release61_fixes repository as http://hg.netbeans.org/release61_fixes/rev/fa56cda1c5b0 changeset: 77484:fa56cda1c5b0 user: samaresh@netbeans.org date: Tue Apr 15 14:25:22 2008 -0500 summary: issue 132362: I18N square boxes in DV with Ja locale rechecked with fcs build and patch1. The fix looks ok with default and 16 fontsize. |