This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Determining default paths | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | novakm <novakm> |
Component: | Mercurial | Assignee: | issues@versioncontrol <issues> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | sustaining |
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | Windows Vista | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | main_work_76920_208cabf1e10e-mercurial-properties-syspaths.patch |
Description
novakm
2008-04-02 08:53:00 UTC
On Solaris if I call "hg incoming" when paths are not set the error below is reported bash-3.2$ hg incoming abort: repository default not found! What happens on Windows? Now I know what happened. It took the default path from per-installation or per-user Mercurial.ini which was set to default = http://hg.netbeans.org/main/. But it was not displayed in mercurial properties on that project so I didn't expect it to do so. The progress bar was indicating something is happening and finally (after several minutes when I was away from my computer) it resulted in error because the line was too long. Now I see the command line behaves the same. So the problem is that it is unsafe to have these paths elsewhere than in hgrc of that repository, is that right? Nothing that can be fixed on our side except maybe a warning dialog that the path was not taken from per-project hgrc? Martin - when you brought up the Mercurial Properties dialog, you should get the push/ pull paths that will be used for this repository, either in the .hg/hgrc, %UserProfile%\Mercurial.ini, or <Install Hg>\Mercurial.ini If you see nothing when .hg\hgrc is not setm but the path is being pulled from %UserProfile%\Mercurial.ini, or <Install Hg>\Mercurial.ini then that's a bug to my mind. We check to see if the push path is null before doing hte push and if it is null warn the user. We also output the push path that was used after the push command completes. I think we should add a "Pushing to <path> ...." in the output window to let the user know what's happening. Confirmed on Solaris: Have nothing set in .hg/hgrc and set default and default-push in ~/.hgrc and you do not see anything in Mercurial->Properties, you should see the paths set in ~/.hgrc That's what I thought. But as I said, default-push and pull is empty (even though username is not) in properties. I've just noticed following text in log: FINE [org.netbeans.modules.mercurial]: Start - Scanning mercurial properties WARNING [org.netbeans.modules.mercurial]: Could not load the file D:\install\6.1_200804020004_javase\projects\hgusername_clone0\.hg\hgrc. Falling back on hg defaults. WARNING [org.netbeans.modules.mercurial]: Could not load the file C:\Users\novakm\Mercurial.ini. Falling back on hg defaults. WARNING [org.netbeans.modules.mercurial]: Could not load the file C:\Users\novakm\Mercurial.ini. Falling back on hg defaults. FINE [org.netbeans.modules.mercurial]: End - Scanning mercurial properties Indeed, there is no %USERPROFILE%\Mercurial.ini, but obviously it uses per-installation file and does not display the values in properties editor. Created attachment 59535 [details]
main_work_76920_208cabf1e10e-mercurial-properties-syspaths.patch
Now fetching sys/global paths if local .hg/hgrc paths have not been set, for display in Mercurial->Properties. Also outputing paths at start of Push/Pull. Committed to main: changeset: 77036:689110f7a019 tag: tip user: jrice@netbeans.org date: Wed Apr 02 11:36:48 2008 +0100 summary: #131794: in Mercurial->Properties only checking .hg/hgrc for Push/Pull need to check system/ global as well Verified in build 200804090003 Merged into release61_fixes repository changeset: 77447:ba293092e4c1 user: jrice@netbeans.org date: Wed Apr 02 11:36:48 2008 +0100 summary: #131794: in Mercurial->Properties only checking .hg/hgrc for pUsh/Pull need to check system/ global as well |