This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | A11Y: Export Diff Patch | ||
|---|---|---|---|
| Product: | versioncontrol | Reporter: | Peter Pis <ppis> |
| Component: | Mercurial | Assignee: | issues@versioncontrol <issues> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | Keywords: | A11Y |
| Priority: | P3 | ||
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: |
initial patch
additional patch main_work_73381_51f01e967a06-username-part2 |
||
Product Version: NetBeans IDE Dev (Build 200802140010) Created attachment 57037 [details]
initial patch
7e469f7d7d11: initial patch which fixes Export Diff dialog is applied. The remaining problems are with the FileChooser. I note that similar problems occur with "Export Diff" dialog for CVS and Subversion. Are there bugs for these? But "Ok" button can have a mnemonic. Other components can't be set. Created attachment 57361 [details]
additional patch
The attached patch makes the mercurial plugin code follow the same pattern as "Export Diff" for subversion. However, there still does not seem to be a mnemonic for the APPROVE_SELECTION button. This is also the case for subversion's "Export Diff" dialog. additional patch pushed in 219c7ce3cbd4. This patch uses the same pattern as Subversion does for JFileChooser. Created attachment 59159 [details]
main_work_73381_51f01e967a06-username-part2
Attached patch to wrong bug - ignore main_work_73381_51f01e967a06-username-part2.patch should be part of fix for #126803 Committed to main: hg changeset: 77079:ff1a85f26792 tag: tip user: jrice@netbeans.org date: Wed Apr 02 16:12:06 2008 +0100 summary: #126803: Username email checking in properties now consistent with Options and also allows userid@localhost Closed in error: hg changeset: 77079:ff1a85f26792 refers to #126803 The remaining issue here is that the OK button in the JFileChooser does not have a mnemonic. This seems to be a Java bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6297220 I am closing this bug the OK button for this FileChooser dialog does not need a mnemonic. The OK text is correct for this dialog as this dialog is just choosing a file not doing the export. Reopen. Issue was fixed. There is "Export" button. Verified. |
Product Version: NetBeans IDE Dev (Build 200802140010) Java: 1.6.0_04; Java HotSpot(TM) Client VM 10.0-b19 System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb) Userdir: D:\ide\61\user =============================================== Tested Window title : Export Diff =============================================== Results of Accessibility test Doesn't implement Accessible : - none. No Accessible name : - none. No Accessible description : Class: javax.swing.JButton { Browse... | } [296,104] Class: javax.swing.JComboBox { Export from: | } [79,57] Class: javax.swing.JTextField { Output File: | } [81,105] =============================================== Tested Window title : Browse for the Export File =============================================== Results of Accessibility test Doesn't implement Accessible : - none. No Accessible name : Class: sun.swing.FilePane$3 { | } [15,67] No Accessible description : Class: com.sun.java.swing.plaf.windows.WindowsFileChooserUI$2 { Look in: | } [60,35] Class: com.sun.java.swing.plaf.windows.WindowsFileChooserUI$4 { File name: | } [92,217] Class: com.sun.java.swing.plaf.windows.WindowsFileChooserUI$6 { OK | } [408,215] Class: javax.swing.JComboBox { Files of type: | } [92,245] Class: sun.swing.FilePane$3 { | } [15,67] Label with LABEL_FOR not set : - none. Components with no LABEL_FOR pointing to it : Class: sun.swing.FilePane$3 { | } [15,67] Components with no mnemonic : Class: com.sun.java.swing.plaf.windows.WindowsFileChooserUI$6 { OK | } [408,215] Class: javax.swing.JButton { New Folder | Create New Folder } [362,36] Class: javax.swing.JButton { Up | Up One Level } [342,36] Class: javax.swing.JToggleButton { Details | Details } [402,36] Class: javax.swing.JToggleButton { List | List } [382,36]