This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Cannot refactor/rename unmanaged files | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | _ tboudreau <tboudreau> |
Component: | Mercurial | Assignee: | issues@versioncontrol <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | ||
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | proposed patch |
Description
_ tboudreau
2008-01-31 17:01:44 UTC
Also: After deleting ForEachToken_1.java, it remained open in the editor - the FileObject did not fire any change that it was invalid. In fact if you make a change and save it, it appears again. I can reproduce this doing Paste | Refactor Copy ... It looks like the problem is with ignored rather than unmanaged files. Part of the fix I have just made for #126385 fixes the first problem you reported. Are the other problems fixed? I cannot reproduce them. Well, if you notice, in the IDE, ForEachToken.java is always annotated as ignored even though it is not. Some bug in the way we parse globs in .hgignore? I've tried: 1. Create new class (A.java) in project under Hg control. 2. "Mercurial | Ignore" action on "A.java". 3. "Refactor | Rename" action on "A.java" to "B.java". 4. "B.java" is [Locally New] 5. "Refactor | Rename" action on "B.java" to "A.java". 6. "A.java" is ignored. Can't it be your case? When I try to follow Peter's instructions I get java.lang.NoClassDefFoundError: org/netbeans/modules/j2ee/core/api/support/java/JavaIdentifiers at org.netbeans.modules.j2ee.jpa.refactoring.PersistenceXmlRefactoring.prepare(PersistenceXmlRefactoring.java:253) at org.netbeans.modules.j2ee.jpa.refactoring.JPARefactoringPlugin.prepare(JPARefactoringPlugin.java:89) [catch] at org.netbeans.modules.refactoring.api.AbstractRefactoring.pluginsPrepare(AbstractRefactoring.java:380) at org.netbeans.modules.refactoring.api.AbstractRefactoring.prepare(AbstractRefactoring.java:202) at org.netbeans.modules.refactoring.spi.impl.ParametersPanel$Prepare.run(ParametersPanel.java:765) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:561) at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:986) Regarding Tim's last comment, I do see that the src directory is ignored. I will try to figure out why. epbuild/anttasks/src matches build/ Is this a problem with .hgignore file? Should this be /build/ The problem seems to be that files which are managed are being reported as ignored. Created attachment 56577 [details]
proposed patch
changeset: 67113:3604215eb339 user: padraigob@netbeans.org date: Wed Feb 13 10:55:22 2008 +0000 files: mercurial/src/org/netbeans/modules/mercurial/FileStatusCache.java mercurial/src/org/netbeans/modules/mercurial/util/HgCommand.java description: 126414: Do not report managed files as ignored. Change createFileInformation to only call HgUtils.isIgnored if hg status is not being called. Undo change for #124323 in HgCommand.getSingleStatus changeset: 67214:80e4cd9a91f7 tag: tip parent: 67113:3604215eb339 parent: 67213:12dd916e0485 user: padraigob@netbeans.org date: Wed Feb 13 10:59:05 2008 +0000 files: websvc.saas.api/build/classes/org/netbeans/modules/websvc/saas/Bundle.properties websvc.saas.api/build/classes/org/netbeans/modules/websvc/saas/resources/layer.xml websvc.saas.api/src/org/netbeans/modules/websvc/saas/resources/layer.xml websvc.saas.ui/src/org/netbeans/modules/websvc/saas/ui/nodes/WadlSaasMethodNode.java description: Automated merge with http://hg.netbeans.org/main |